Skip to content

fix(sdk): remove unused workflowId parameter from localizeChunk #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndreyHirsa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sdk): remove unused workflowId parameter from localizeChunk #2038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-nails-notice.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@lingo.dev/_sdk": patch
---

Remove unused workflowId parameter from internal localizeChunk method
4 changes: 0 additions & 4 deletions packages/sdk/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ export class LingoDotDevEngine {
const chunkedPayload = this.extractPayloadChunks(finalPayload);
const processedPayloadChunks: Record<string, string>[] = [];

const workflowId = createId();
for (let i = 0; i < chunkedPayload.length; i++) {
const chunk = chunkedPayload[i];
const percentageCompleted = Math.round(
Expand All @@ -87,7 +86,6 @@ export class LingoDotDevEngine {
finalParams.sourceLocale,
finalParams.targetLocale,
{ data: chunk, reference: params.reference, hints: params.hints },
workflowId,
params.fast || false,
params.filePath,
params.triggerType,
Expand All @@ -109,7 +107,6 @@ export class LingoDotDevEngine {
* @param sourceLocale - Source locale
* @param targetLocale - Target locale
* @param payload - Payload containing the chunk to be localized
* @param workflowId - Workflow ID for tracking
* @param fast - Whether to use fast mode
* @param filePath - Optional file path for metadata
* @param triggerType - Optional trigger type
Expand All @@ -124,7 +121,6 @@ export class LingoDotDevEngine {
reference?: Z.infer<typeof referenceSchema>;
hints?: Z.infer<typeof hintsSchema>;
},
workflowId: string,
fast: boolean,
filePath?: string,
triggerType?: "cli" | "ci",
Expand Down