TPT-4264: Create tests for Create Linodes Options and Password-less#887
Conversation
psnoch-akamai
requested review from
jbilskiAkam and
mawilk90
and removed request for
a team
| must_end = time.time() + timeout | ||
| while time.time() < must_end: | ||
| time.sleep(period) | ||
| result = exec_test_command( |
There was a problem hiding this comment.
Please verify if test pass for you. I get error randomly:
E Request failed: 404
E Not found
There was a problem hiding this comment.
Yes, it fails so maybe usage of wait_for_condition is going to help (as mentioned here)?
There was a problem hiding this comment.
I'm also getting the 404
There was a problem hiding this comment.
The same result with wait_for_condition. Seems like API issue and if status is not ready it is not available for some time
psnoch-akamai
changed the title
|
It's worth to mention that using openapi.json from TECH doc PR mentioned in the description will fail with the current linode-cli's parser. Solution provided here |
|
|
||
|
|
||
| def wait_for_disk_status( | ||
| linode_id: "str", disk_id: "str", timeout, status: "str", period=10 |
There was a problem hiding this comment.
Is it not possible to use existing wait_for_condition instead of creating a new method?
There was a problem hiding this comment.
Good idea, but probably I need to use custom one, because of 404 error
psnoch-akamai
force-pushed
the
TPT-4264-linode-cli-add-integration-tests-for-expand-create-linodes-options-and-password-less
branch
from
7ef03e3 to
2241491
Compare
psnoch-akamai
force-pushed
the
TPT-4264-linode-cli-add-integration-tests-for-expand-create-linodes-options-and-password-less
branch
from
cb2d072 to
36e4858
Compare
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
Tests passing locally. Nice work!
3 participants
✔️ How to Test
make test-int TEST_CASE=test_expected_error_if_fields_authorized_users_authorized_keys_root_pass_are_not_set
make test-int TEST_CASE=test_create_linode_with_kernel_and_boot_size_then_add_disk_and_rebuild
TECH doc PR: https://git.source.akamai.com/projects/TECHDOCS/repos/akamai-api-inventory/pull-requests/2685/overview - to build it fix from #888 is needed