TPT-3809: Added DiskEncryption field for LKE Node Pool creation#670
Open
ezilber-akamai wants to merge 2 commits intolinode:devfrom
Open
TPT-3809: Added DiskEncryption field for LKE Node Pool creation#670ezilber-akamai wants to merge 2 commits intolinode:devfrom
ezilber-akamai wants to merge 2 commits intolinode:devfrom
Conversation
ezilber-akamai
requested review from
Copilot,
lgarber-akamai and
yec-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Adds SDK support for setting disk_encryption when creating an LKE node pool via the POST /lke/clusters/{id}/pools operation, plus an integration test to validate the behavior.
Changes:
- Add
disk_encryptionparameter toLKECluster.node_pool_create()and include it in the POST payload. - Add an integration test that creates a node pool with disk encryption enabled and asserts the returned value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
linode_api4/objects/lke.py |
Extends LKECluster.node_pool_create() to accept and send disk_encryption in the request body. |
test/integration/models/lke/test_lke.py |
Adds an integration test covering node pool creation with disk_encryption="enabled". |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ezilber-akamai
force-pushed
the
TPT-3809-lde-for-lke
branch
from
82d87bf to
2ad2528
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ezilber-akamai
force-pushed
the
TPT-3809-lde-for-lke
branch
from
2ad2528 to
d4cc572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for DiskEncryption field in LKE Node Pool POST operation.
✔️ How to Test
make test-int TEST_CASE=test_node_pool_create_with_disk_encryption