TPT-4056: Fix GitHub Actions script injection vulnerability#1006
Open
zliang-akamai wants to merge 1 commit into
Open
TPT-4056: Fix GitHub Actions script injection vulnerability#1006zliang-akamai wants to merge 1 commit into
zliang-akamai wants to merge 1 commit into
Conversation
zliang-akamai
requested review from
lgarber-akamai and
psnoch-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the integration_tests_pr.yml workflow against GitHub Actions script-injection by removing direct interpolation of the workflow_dispatch module input inside a run: command and instead passing it via an environment variable.
Changes:
- Replaced
${{ inputs.module }}usage in therun:shell command with$MODULE. - Added
MODULE: ${{ inputs.module }}as a step-level environment variable for the guarded fixtures step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zliang-akamai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Pass the workflow dispatch input through a step-level environment variable to prevent script injection without changing fixture-test behavior.