ci: use tox-lsr 3.18.1 [citest_skip]

[richm]

Use tox-lsr 3.18.1

Summary by Sourcery

Update CI workflows to use the newer tox-lsr release and separate collection conversion from subsequent ansible checks.

CI:

• Bump tox-lsr used in GitHub Actions workflows from 3.18.0 to 3.18.1.
• Split ansible-lint and ansible-test workflows to run the collection conversion step separately from the lint/test tox environments.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitHub Actions CI workflows to use tox-lsr 3.18.1 and separates the collection-conversion step from ansible-lint/ansible-test runs while adjusting tox environment invocations accordingly.

Sequence diagram for updated ansible-lint CI workflow

sequenceDiagram
    actor Developer
    participant GitHubActions as GitHub_Actions
    participant Runner as CI_Runner
    participant Pip as pip3
    participant Tox as tox
    participant ToxLSR as tox_lsr_3_18_1
    participant AnsibleLint as ansible_lint_collection

    Developer->>GitHubActions: Push or open PR
    GitHubActions->>Runner: Start ansible_lint workflow job

    Runner->>Pip: Install git+https://github.com/linux-system-roles/tox-lsr@3.18.1
    Pip-->>Runner: tox_lsr_3_18_1 installed

    Runner->>Tox: Run tox -e collection
    Tox->>ToxLSR: Invoke collection env to convert role
    ToxLSR-->>Tox: Role converted to collection format
    Tox-->>Runner: collection env completed

    Runner->>Tox: Run tox -e ansible-lint-collection with LSR_ANSIBLE_LINT_* env vars
    Tox->>AnsibleLint: Execute ansible_lint_collection env
    AnsibleLint-->>Tox: Lint results
    Tox-->>Runner: ansible-lint-collection completed
    Runner-->>GitHubActions: Job status reported
    GitHubActions-->>Developer: CI status updated

Loading

File-Level Changes

Change	Details	Files
Bump tox-lsr dependency version used in GitHub Actions workflows.	Update pip install command to use tox-lsr version 3.18.1 instead of 3.18.0 in lint, test, managed-var-comment, and qemu-kvm integration workflows	.github/workflows/ansible-lint.yml .github/workflows/ansible-test.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/qemu-kvm-integration-tests.yml
Refine ansible-lint workflow to run collection conversion and linting as separate tox steps.	Add a dedicated step that runs tox -e collection to perform role-to-collection conversion Update ansible-lint step to only run the ansible-lint tox environment and drop the collection environment from the -e list while preserving environment variable overrides and basepython selection via -x	.github/workflows/ansible-lint.yml
Refine ansible-test workflow to run collection conversion and ansible-test as separate tox steps.	Add a dedicated step that runs tox -e collection for role-to-collection conversion Update ansible-test step to only run the ansible-test tox environment and drop the collection environment from the -e list while preserving basepython selection via -x	.github/workflows/ansible-test.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}