Skip to content

feat: new variable trustee_client_secure_logging defaulting to true#32

Merged
richm merged 1 commit into
linux-system-roles:mainfrom
spetrosi:parametrize-no-log
May 7, 2026
Merged

feat: new variable trustee_client_secure_logging defaulting to true#32
richm merged 1 commit into
linux-system-roles:mainfrom
spetrosi:parametrize-no-log

Conversation

@spetrosi
Copy link
Copy Markdown
Contributor

@spetrosi spetrosi commented May 7, 2026

Feature: Introduce the trustee_client_secure_logging variable that defaults to true.

Reason: Currently, all sensitive tasks use hard-coded no_log: true, which makes debugging difficult. Users cannot see credential-related output even when troubleshooting authentication or secret management issues.

Result:

  • Tasks handling credentials, secrets, and sensitive data now use no_log: "{{ trustee_client_secure_logging }}", allowing users to set trustee_client_secure_logging: false for debugging while maintaining secure defaults (true)
  • New variable trustee_client_secure_logging documented in README.md with guidance on when to disable it
  • Users can now debug credential and secret issues without modifying role code

🤖 Generated with Claude Code

- Replace literal no_log: true with trustee_client_secure_logging variable
- Add trustee_client_secure_logging: true to defaults/main.yml
- Document trustee_client_secure_logging variable in README.md

This change allows users to control logging of potentially sensitive
information by setting trustee_client_secure_logging: false for debugging,
while maintaining secure defaults.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@spetrosi spetrosi requested a review from richm as a code owner May 7, 2026 12:52
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We failed to fetch pull request #32.

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

@richm richm merged commit d24e9d2 into linux-system-roles:main May 7, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants