feat: new variable trustee_client_secure_logging defaulting to true#32
Merged
Merged
Conversation
- Replace literal no_log: true with trustee_client_secure_logging variable - Add trustee_client_secure_logging: true to defaults/main.yml - Document trustee_client_secure_logging variable in README.md This change allows users to control logging of potentially sensitive information by setting trustee_client_secure_logging: false for debugging, while maintaining secure defaults. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
We failed to fetch pull request #32.
You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.
richm
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Introduce the
trustee_client_secure_loggingvariable that defaults totrue.Reason: Currently, all sensitive tasks use hard-coded no_log: true, which makes debugging difficult. Users cannot see credential-related output even when troubleshooting authentication or secret management issues.
Result:
🤖 Generated with Claude Code