driver: ddramc: fix JEDEC timing#199
Open
sonicpp wants to merge 1 commit into
Open
Conversation
tWTR is defined in ns unit, so it has to be converted to tCK. tXSRD, on the other hand, is already in tCK. Signed-off-by: Jan Havran <jan.havran@advantech.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tWTR is defined in ns unit, so it has to be converted to tCK, while tXSRD, on the other hand, is already in tCK.
This can be seen for example when the DDR timing is defined as
then the values are correct:
tWTR=2
tXSRD=200
But when setting following option
then the values are wrong:
tWTR=8
tXSRD=40
while these values should be same as above as per JEDEC specs.