initrd/bin/kexec-save-default.sh: skip symlinks when finding crypttabfiles#2155
Open
tlaurion wants to merge 1 commit into
Open
initrd/bin/kexec-save-default.sh: skip symlinks when finding crypttabfiles#2155tlaurion wants to merge 1 commit into
tlaurion wants to merge 1 commit into
Conversation
… files - NixOS initrds contain /etc/crypttab as a symlink to a Nix store path (e.g. /nix/store/<hash>-initrd-crypttab). When unpacked into /tmp/initrd_extract, the symlink target is an absolute path that does not exist on the Heads recovery system, making cat fail. - find without -type f matched the dangling symlink, causing cat to error out inside a pipefail pipeline, which killed the crypttab parsing loop and caused kexec-save-default.sh to fail. - Add -type f to only match regular files, skipping symlinks. Signed-off-by: Thierry Laurion <insurgo@riseup.net>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result, a crypttab is generated pointing key unsealed and injected TPM DUK through passphrase in additional cpio passed alongside initramfs on kexec call, and that injected cpio successfully decrypt my 2 luks container setup described under #2154
It is to note that unencrypted /boot support option from installer was sadly completely removed in the aftermath of #1348. I am unaware of when /boot got completely removed, which I find sad, requiring manual partitioning. At least, this PR permits TPM DUK on "brainless" partitionning scheme, where iniramfs can decrypt rootfs partitioning with swap, without needing rootfs to be already decrypted. If someone is from/within NixOS and wants to tackle the installer issues, be my guest :)
Fixes #2154