fix: remove duplicate title label in timeout dialog#3247
Conversation
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves a redundant title Label from the timeout dialog QML so the title is only rendered by the dialog header, avoiding duplicated text in the UI. Sequence diagram for timeout dialog title rendering after fixsequenceDiagram
actor User
participant TimeoutDialog
participant DialogHeader
User->>TimeoutDialog: open()
TimeoutDialog->>DialogHeader: setTitle(title)
DialogHeader-->>User: render title
%% Previously: extra Label in TimeoutDialog also rendered title
%% Now: only DialogHeader renders title (no duplicate Label)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
417b486 to
295faa1
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1. Remove the redundant title Label from TimeoutDialog.qml 2. The title text is already displayed via the dialog header, so the extra Label caused a duplicate display issue Log: Remove duplicate title label from display timeout dialog fix: 移除超时对话框中重复的标题标签 1. 从 TimeoutDialog.qml 中移除冗余的标题 Label 2. 标题文本已通过对话框头部显示,多余的 Label 导致标题重复展示 Log: 移除显示超时对话框中重复的标题标签 PMS: BUG-362237
295faa1 to
b90056b
Compare
|
/merge |
|
This pr cannot be merged! (status: blocked) |
Log: Remove duplicate title label from display timeout dialog
fix: 移除超时对话框中重复的标题标签
Log: 移除显示超时对话框中重复的标题标签
PMS: BUG-362237
Summary by Sourcery
Bug Fixes: