Skip to content

fix: remove duplicate title label in timeout dialog#3247

Merged
mhduiy merged 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0521-fix-issue-362237
May 22, 2026
Merged

fix: remove duplicate title label in timeout dialog#3247
mhduiy merged 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0521-fix-issue-362237

Conversation

@MyLeeJiEun
Copy link
Copy Markdown
Contributor

@MyLeeJiEun MyLeeJiEun commented May 21, 2026

  1. Remove the redundant title Label from TimeoutDialog.qml
  2. The title text is already displayed via the dialog header, so the extra Label caused a duplicate display issue

Log: Remove duplicate title label from display timeout dialog

fix: 移除超时对话框中重复的标题标签

  1. 从 TimeoutDialog.qml 中移除冗余的标题 Label
  2. 标题文本已通过对话框头部显示,多余的 Label 导致标题重复展示

Log: 移除显示超时对话框中重复的标题标签
PMS: BUG-362237

Summary by Sourcery

Bug Fixes:

  • Resolve duplicate title text in the display timeout dialog by removing an extra label.

@deepin-ci-robot
Copy link
Copy Markdown

Hi @MyLeeJiEun. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 21, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes a redundant title Label from the timeout dialog QML so the title is only rendered by the dialog header, avoiding duplicated text in the UI.

Sequence diagram for timeout dialog title rendering after fix

sequenceDiagram
    actor User
    participant TimeoutDialog
    participant DialogHeader

    User->>TimeoutDialog: open()
    TimeoutDialog->>DialogHeader: setTitle(title)
    DialogHeader-->>User: render title
    %% Previously: extra Label in TimeoutDialog also rendered title
    %% Now: only DialogHeader renders title (no duplicate Label)
Loading

File-Level Changes

Change Details Files
Remove the extra title label from the timeout dialog layout so the title is only shown once.
  • Delete the top Label in the dialog content that bound its text to the title property and applied bold, centered styling
  • Keep the remaining Label (presumably for body/description text) as-is to continue showing the dialog message
src/plugin-display/qml/TimeoutDialog.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@MyLeeJiEun MyLeeJiEun force-pushed the fork-from-master-0521-fix-issue-362237 branch from 417b486 to 295faa1 Compare May 22, 2026 01:29
@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, MyLeeJiEun

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1. Remove the redundant title Label from TimeoutDialog.qml
2. The title text is already displayed via the dialog header,
   so the extra Label caused a duplicate display issue

Log: Remove duplicate title label from display timeout dialog

fix: 移除超时对话框中重复的标题标签

1. 从 TimeoutDialog.qml 中移除冗余的标题 Label
2. 标题文本已通过对话框头部显示,多余的 Label 导致标题重复展示

Log: 移除显示超时对话框中重复的标题标签
PMS: BUG-362237
@MyLeeJiEun MyLeeJiEun force-pushed the fork-from-master-0521-fix-issue-362237 branch from 295faa1 to b90056b Compare May 22, 2026 02:07
@MyLeeJiEun
Copy link
Copy Markdown
Contributor Author

/merge

@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented May 22, 2026

This pr cannot be merged! (status: blocked)

@mhduiy mhduiy merged commit 0672597 into linuxdeepin:master May 22, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants