fix(authentication): fix background persisting and buttons misalignment after cancel rename

[52cyb]

Replace manual Rectangle + TextInput with D.LineEdit + D.EditPanel to properly manage alert state, ensuring background resets when rename validation is canceled and buttons stay right-aligned.

替换手动Rectangle+TextInput为D.LineEdit+D.EditPanel，正确管理alert状态，确保取消重命名验证后背景复位，编辑按钮保持右对齐。

Log: 修复取消重命名后背景仍置红及编辑按钮偏左的问题
PMS: 361553
Influence: 1.关闭授权框后背景正确恢复；2.编辑按钮保持右对齐；3.提示文案的显示效果和位置正确。

Summary by Sourcery

Improve the authentication rename field to use standard input components with integrated validation and alert handling.

New Features:

• Use D.LineEdit with D.EditPanel for the authentication item rename input to integrate visual alerts and background handling.

Bug Fixes:

• Ensure the rename field background resets correctly after cancelling validation and closing the authorization dialog.
• Keep the edit/rename action buttons right-aligned when validation fails or is cancelled.
• Fix positioning and display of validation message text for the rename field.

Enhancements:

• Centralize and streamline inline validation for authentication item renaming, including character filtering, length checks, and duplicate-name detection.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 52cyb

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepin-ci-robot]

Hi @52cyb. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sourcery-ai]

Reviewer's Guide

Refactors the authentication name edit field to use D.LineEdit with D.EditPanel for built‑in alert handling and focus management, fixing the lingering red background and ensuring action buttons remain right-aligned after canceling rename validation.

Sequence diagram for updated rename validation and alert handling

sequenceDiagram
    actor User
    participant EditButton as EditButton
    participant LineEdit as nameEditor_D_LineEdit
    participant EditPanel as nameEditPanel_D_EditPanel
    participant Layout as layout

    User->>EditButton: onClicked
    EditButton->>LineEdit: readOnly = false
    EditButton->>LineEdit: forceActiveFocus()

    User->>LineEdit: onTextEdited
    LineEdit->>EditPanel: showAlert = false
    LineEdit->>LineEdit: filter text / enforce maxLength
    alt [text length > maxLength]
        LineEdit->>EditPanel: showAlert = true
        LineEdit->>EditPanel: alertText = qsTr("No more than 15 characters")
    end

    User->>LineEdit: onEditingFinished
    alt [readOnly]
        LineEdit-->>User: return (no change)
    else [!checkInputInvalid()]
        LineEdit->>EditPanel: showAlert = false
        LineEdit->>LineEdit: text = modelData
        LineEdit->>LineEdit: text = Qt.binding(modelData)
    else [checkInputInvalid()]
        LineEdit->>LineEdit: readOnly = true
        alt [modelData != text]
            LineEdit->>Layout: requestRename(modelData, text)
        end
        LineEdit->>LineEdit: text = Qt.binding(modelData)
    end

Loading

File-Level Changes

Change	Details	Files
Replace custom Rectangle+TextInput combo with D.LineEdit+D.EditPanel and inline validation logic for the authentication name editor.	Swap manual Rectangle/TextInput wrapper for a D.LineEdit control configured with read-only default, horizontal alignment, max length, and content-based width constraints. Introduce a D.EditPanel as the LineEdit background to manage alert visuals (showAlert, alertText, alertDuration, transparent normal background) instead of manually coloring a Rectangle. Port and adapt the onTextEdited logic to sanitize input (allowed characters and length) while clearing any existing alerts and showing panel-based alerts on overflow. Refactor editingFinished handling to early-return when still read-only, reset alerts, validate using a new checkInputInvalid function, and either revert to modelData or call layout.requestRename before rebinding text to modelData. Reimplement checkInputInvalid to compute validity/length/duplicate-name states using nameEditor.text and drive D.EditPanel alerts with specific messages, returning a boolean for the caller. Update the edit button click handler to toggle nameEditor.readOnly to false and request focus via forceActiveFocus instead of directly manipulating the old TextInput.	src/plugin-authentication/qml/AuthenticationMain.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The validation logic in checkInputInvalid is tightly coupled to nameEditor and duplicated between onTextEdited and the function; consider centralizing the validation (including maxLength and illegal-character checks) into a single helper to avoid divergence and make future changes safer.
• When cancelling or resetting the edit (e.g. on invalid input), you rebind nameEditor.text to modelData but leave readOnly and focus handling spread across onEditingFinished and the action button; consolidating the state reset into a small helper (resetReadOnly/resetToModelData) would make the rename lifecycle easier to follow and less error‑prone.
• Right now alerts are shown and hidden by directly toggling nameEditPanel.showAlert in several places; you might want a small wrapper function (e.g. showAlert(msg) / clearAlert()) to avoid repeating the pattern and ensure all call sites behave consistently when alerts are dismissed or editing restarts.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The validation logic in `checkInputInvalid` is tightly coupled to `nameEditor` and duplicated between `onTextEdited` and the function; consider centralizing the validation (including maxLength and illegal-character checks) into a single helper to avoid divergence and make future changes safer.
- When cancelling or resetting the edit (e.g. on invalid input), you rebind `nameEditor.text` to `modelData` but leave `readOnly` and focus handling spread across `onEditingFinished` and the action button; consolidating the state reset into a small helper (resetReadOnly/resetToModelData) would make the rename lifecycle easier to follow and less error‑prone.
- Right now alerts are shown and hidden by directly toggling `nameEditPanel.showAlert` in several places; you might want a small wrapper function (e.g. `showAlert(msg)` / `clearAlert()`) to avoid repeating the pattern and ensure all call sites behave consistently when alerts are dismissed or editing restarts.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}