feat: [GPU] Add logic to show GPU info.#497
Merged
deepin-bot[bot] merged 1 commit intoJul 24, 2025
Merged
Conversation
-- In some special computer, the GPU info not show. -- Add logic to show GPU info. -- Remove duplicate code and improve code readability. Log: add feature for GPU. Task: https://pms.uniontech.com/task-view-378987.html
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's GuideThis PR refactors GPU information extraction by removing the in-class EDID parser and delegating that logic to a shared CommonTools implementation. It adds the necessary header, deletes the duplicate static function, and updates the generatorMonitorDevice method to invoke CommonTools::parseEDID. Sequence diagram for GPU info extraction using CommonTools::parseEDIDsequenceDiagram
participant HWGenerator
participant CommonTools
participant DeviceMonitor
participant DeviceManager
HWGenerator->>CommonTools: parseEDID(allEDIDS_all, interface)
CommonTools->>DeviceMonitor: setInfoFromEdid(mapInfo)
CommonTools->>DeviceManager: addMonitor(device)
Class diagram for HWGenerator and CommonTools after GPU info refactorclassDiagram
class HWGenerator {
+void generatorMonitorDevice()
+void getMemoryInfoFromLshw()
}
class CommonTools {
+static void parseEDID(QStringList allEDIDS, QString input)
}
HWGenerator ..> CommonTools : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
max-lvs
approved these changes
Jul 24, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GongHeng2017, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-- In some special computer, the GPU info not show. -- Add logic to show GPU info.
-- Remove duplicate code and improve code readability.
Log: add feature for GPU.
Task: https://pms.uniontech.com/task-view-378987.html
Summary by Sourcery
Add GPU information display by integrating unified EDID parsing and refactoring duplicate code
New Features:
Enhancements: