Skip to content

fix: update translations#510

Closed
JWWTSL wants to merge 0 commit into
linuxdeepin:masterfrom
JWWTSL:master
Closed

fix: update translations#510
JWWTSL wants to merge 0 commit into
linuxdeepin:masterfrom
JWWTSL:master

Conversation

@JWWTSL
Copy link
Copy Markdown
Contributor

@JWWTSL JWWTSL commented Aug 8, 2025

log:

Summary by Sourcery

Add complete Lao locale support by providing translations for the main application, desktop entry and policy files.

New Features:

  • Add Lao translations for deepin-devicemanager UI strings
  • Provide Lao translations for desktop entry descriptions
  • Include Lao translations for policy authentication prompts

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 8, 2025

Reviewer's Guide

This pull request introduces complete Lao language support by adding new translation files and populating all relevant UI, desktop entry, and policy messages in .ts format.

File-Level Changes

Change Details Files
Add main application translation file for Lao
  • Create deepin-devicemanager_lo.ts under translations
  • Import and map ~3965 source strings to Lao
  • Cover all UI contexts (widgets, pages, device info)
deepin-devicemanager/translations/deepin-devicemanager_lo.ts
Add desktop entry translations
  • Create desktop_lo.ts under translations/desktop
  • Translate application name, generic name, and comment
deepin-devicemanager/translations/desktop/desktop_lo.ts
Add policy prompt translations
  • Create policy_lo.ts under translations/policy
  • Translate authentication and dialog button texts
deepin-devicemanager/translations/policy/policy_lo.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 8, 2025

TAG Bot

TAG: 6.0.48
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

这个提交主要是更新了 deepin-devicemanager 的版本号,从 6.0.47 更新到 6.0.48。从代码审查的角度来看,这个提交没有涉及到实际的代码逻辑,因此主要关注点在于版本号更新的正确性和提交信息的完整性。

代码审查意见

  1. 版本号更新

    • 确认版本号更新是否正确,是否符合语义化版本控制规范(Semantic Versioning)。
    • 检查是否有对应的代码变更支持这个版本号的更新。
  2. 提交信息

    • 提交信息应该简洁明了,清晰地说明版本更新的原因和内容。
    • 在这个提交中,提交信息只提到了“Update version to 6.0.48”,可以进一步补充说明更新的具体内容或原因。
  3. 日志记录

    • 如果这个版本更新涉及到具体的代码变更,建议在提交信息中添加相关的日志记录,以便于后续的代码审查和维护。

改进后的提交信息示例

deepin-devicemanager (6.0.48) unstable; urgency=medium

  * Update version to 6.0.48.
  * Add support for new device type XYZ.
  * Improve performance by optimizing XYZ algorithm.

 -- Tian ShiLin <tianshilin@uniontech.com>  Fri, 08 Aug 2025 13:29:09 +0800

这个改进后的提交信息提供了更多的上下文,帮助其他开发者理解版本更新的具体内容。

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JWWTSL

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JWWTSL - I've reviewed your changes - here's some feedback:

  • Please review the TS files for inconsistent or unintended non-Lao entries (e.g. Russian fragments) and ensure all translations are in the target language.
  • There are duplicate translations for keys like “OK” with different Lao variants—please consolidate them for consistency across the UI.
  • Consider running Qt’s lupdate/lrelease and using Qt Linguist to manage placeholders (e.g. %1) and avoid manual entry errors.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Please review the TS files for inconsistent or unintended non-Lao entries (e.g. Russian fragments) and ensure all translations are in the target language.
- There are duplicate translations for keys like “OK” with different Lao variants—please consolidate them for consistency across the UI.
- Consider running Qt’s lupdate/lrelease and using Qt Linguist to manage placeholders (e.g. %1) and avoid manual entry errors.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants