Skip to content

ORCH-001: handle regular PR comments in await_review#14

Open
linuxlewis wants to merge 2 commits into
masterfrom
sam/orch-001-pr-comment-review
Open

ORCH-001: handle regular PR comments in await_review#14
linuxlewis wants to merge 2 commits into
masterfrom
sam/orch-001-pr-comment-review

Conversation

@linuxlewis
Copy link
Copy Markdown
Owner

Summary

  • treat regular PR conversation comments as actionable review feedback when they arrive after the author's last response activity
  • route successful await_review poll results through route-review.sh so commented enters handle_review while approvals still advance to merge
  • add script-level coverage for comment detection baselines and runner coverage for the new review-state routing

Why

Maintainer feedback posted as normal PR conversation comments was being ignored by await_review, so tickets could sit idle unless feedback arrived as a formal review or unresolved line-comment thread.

Validation

  • pnpm run lint:fix
  • pnpm run typecheck
  • pnpm run test

Ticket

  • ORCH-001

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the PR review checking logic by introducing a Node.js script to identify actionable conversation comments and follow-up activity. It also adds a new route-review.sh script and updates the standard workflow to handle different review states like commented or changes_requested. Feedback was provided to simplify several shell script conditional checks by using arithmetic comparisons for better readability and idiomatic consistency.

Comment thread scripts/check-pr-review.sh Outdated
Comment thread scripts/check-pr-review.sh Outdated
Comment thread scripts/check-pr-review.sh Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant