ORCH-001: handle regular PR comments in await_review#14
Open
linuxlewis wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request enhances the PR review checking logic by introducing a Node.js script to identify actionable conversation comments and follow-up activity. It also adds a new route-review.sh script and updates the standard workflow to handle different review states like commented or changes_requested. Feedback was provided to simplify several shell script conditional checks by using arithmetic comparisons for better readability and idiomatic consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
route-review.shsocommentedentershandle_reviewwhile approvals still advance to mergeWhy
Maintainer feedback posted as normal PR conversation comments was being ignored by
await_review, so tickets could sit idle unless feedback arrived as a formal review or unresolved line-comment thread.Validation
pnpm run lint:fixpnpm run typecheckpnpm run testTicket