Fixes to address continuous spinner on api call failure#5
Open
henrymchu wants to merge 1 commit into
Open
Conversation
Contributor
henrymchu
commented
Mar 12, 2026
henrymchu
commented
- UsageData.swift — Added ExtraUsage struct to match the updated API response shape (nullable utilization, is_enabled, etc.)
- UsageViewModel.swift — Updated highestUtilization and displayLimits to handle the new ExtraUsage type
- ContentView.swift — Fixed the network error state being hidden behind the toolbar (now shows an error screen with Retry + Open Settings buttons when there's no data)
* UsageData.swift — Added ExtraUsage struct to match the updated
API response shape (nullable utilization, is_enabled, etc.)
* UsageViewModel.swift — Updated highestUtilization and
displayLimits to handle the new ExtraUsage type
* ContentView.swift — Fixed the network error state being hidden
behind the toolbar (now shows an error screen with Retry +
Open Settings buttons when there's no data)
|
Would be great to merge this PR as currently the latest release v1.2.0 is broken. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.