feat(data-dictionary): co-locate dialect packages and consolidate domain SQL - #688
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
- Coverage 77.41% 77.39% -0.03%
==========================================
Files 476 486 +10
Lines 68266 68278 +12
Branches 9403 9405 +2
==========================================
- Hits 52849 52844 -5
- Misses 12013 12024 +11
- Partials 3404 3410 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cofin
force-pushed
the
feat/data-dictionary-sql-consolidation
branch
2 times, most recently
from
August 8, 2026 23:39
e4b20c8 to
650738a
Compare
cofin
force-pushed
the
feat/data-dictionary-sql-consolidation
branch
from
August 9, 2026 15:16
650738a to
0eaf874
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the data dictionary subsystem in
sqlspec/data_dictionary/to co-locate Python dialect modules and SQL query files into package directories per database engine.Changes Included
sqlspec/data_dictionary/dialects/<dialect>.pyinto package directoriessqlspec/data_dictionary/dialects/<dialect>/containingconfig.py(defines<DIALECT>_CONFIG) and__init__.py(re-exports config & helpers)..sqlquery files (columns.sql,tables.sql,indexes.sql, etc.) insidesqlspec/data_dictionary/dialects/<dialect>/sql/.DataDictionaryLoaderin_loader.pyto lazy-load domain.sqlfiles viaimportlib.resources.files(f"sqlspec.data_dictionary.dialects.{dialect}.sql").joinpath(f"{domain}.sql").sqlspec/data_dictionary/sql/directory tree.Quality Gates
make lintpassed (ruff lint, format, mypy, pyright, slotscheck, codespell, zizmor).uv run pytest tests/unit/data_dictionary/passed (125/125 unit tests green).