Skip to content

fix(agents): clear pending auto tool reply on timeout#1494

Closed
rosetta-livekit-bot[bot] wants to merge 1 commit into
mainfrom
fix-auto-tool-reply-timeout
Closed

fix(agents): clear pending auto tool reply on timeout#1494
rosetta-livekit-bot[bot] wants to merge 1 commit into
mainfrom
fix-auto-tool-reply-timeout

Conversation

@rosetta-livekit-bot
Copy link
Copy Markdown
Contributor

@rosetta-livekit-bot rosetta-livekit-bot Bot commented May 13, 2026

Summary

The timeout branch of _wait_for_auto_tool_reply (in auto_tool_reply_generation setup, added in #5702) leaves self._pending_auto_tool_reply_fut set to the stale future. A subsequent tool execution then short-circuits the wait-setup guard (is None), so RunResult is not held open for the next realtime auto reply.

Move the cleanup into a finally block. The success path is already cleared in _on_generation_created; the is auto_reply_fut guard keeps the finally a no-op there.

Reproducing

A realtime model with auto_tool_reply_generation=True whose first auto-reply takes >5s — the run completes after the warning, then the next tool turn returns from sess.run(...) before the auto-reply.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 13, 2026

🦋 Changeset detected

Latest commit: 127b47b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@livekit/agents Patch
@livekit/agents-plugin-anam Patch
@livekit/agents-plugin-assemblyai Patch
@livekit/agents-plugin-baseten Patch
@livekit/agents-plugin-bey Patch
@livekit/agents-plugin-cartesia Patch
@livekit/agents-plugin-cerebras Patch
@livekit/agents-plugin-deepgram Patch
@livekit/agents-plugin-elevenlabs Patch
@livekit/agents-plugin-fishaudio Patch
@livekit/agents-plugin-google Patch
@livekit/agents-plugin-hedra Patch
@livekit/agents-plugin-hume Patch
@livekit/agents-plugin-inworld Patch
@livekit/agents-plugin-lemonslice Patch
@livekit/agents-plugin-liveavatar Patch
@livekit/agents-plugin-livekit Patch
@livekit/agents-plugin-minimax Patch
@livekit/agents-plugin-mistral Patch
@livekit/agents-plugin-mistralai Patch
@livekit/agents-plugin-neuphonic Patch
@livekit/agents-plugin-openai Patch
@livekit/agents-plugin-phonic Patch
@livekit/agents-plugin-resemble Patch
@livekit/agents-plugin-rime Patch
@livekit/agents-plugin-runway Patch
@livekit/agents-plugin-sarvam Patch
@livekit/agents-plugin-silero Patch
@livekit/agents-plugins-test Patch
@livekit/agents-plugin-trugen Patch
@livekit/agents-plugin-xai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@u9g u9g closed this May 13, 2026
@u9g u9g deleted the fix-auto-tool-reply-timeout branch May 13, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant