Add room deletion on agent session close#1501
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 392e5ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf736998c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
theomonnom
reviewed
May 13, 2026
…it/agents-js into brian/delete-room-on-close
theomonnom
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JobContext.deleteRoom()for deleting the current or specified LiveKit room.RoomInputOptions.deleteRoomOnClose, defaulting tofalse, and wireRoomIOto delete the room when the agent session closes.JobContextwhenRoomIOis created and awaiting the delete task during RoomIO teardown.Test plan
pnpm test agents/src/job.test.ts agents/src/voice/agent_session.test.ts agents/src/voice/room_io/room_io.test.tspnpm build:agentsexamples/src/basic_agent.tsby enablingdeleteRoomOnCloseand confirming the room deletion completed on session close.