refactor(elevenlabs): abort recv channel on ws close/error#1505
Merged
Conversation
Push the error into the message channel via abort() so the next reader.read() rejects inline, instead of holding it in a side Future and checking after the loop. Mirrors how Python's _recv_loop raises directly from await ws.receive().
🦋 Changeset detectedLatest commit: 8b2c93d The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
toubatbrian
reviewed
May 14, 2026
toubatbrian
reviewed
May 14, 2026
toubatbrian
approved these changes
May 15, 2026
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the side-channel
Future<Error>in the TTS recv loop with amessageChannel.abort(err)call from the ws event handlers, so the pendingreader.read()rejects inline. Mirrors Python's_recv_loop, which raises directly fromawait ws.receive().Changes Made
onClose/onErrornow callmessageChannel.abort(err)instead of resolving a separateFutureif (errorFuture.done) throwcheck — the outertry/catchhandles itFutureimportPre-Review Checklist
Testing
openai/STTVAD)