(feat) 11Labs STT : Add enable_logging#6273
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
tinalenguyen
left a comment
tinalenguyen
left a comment
There was a problem hiding this comment.
thanks for the PR! i left a few comments
| model_id: NotGivenOr[ElevenLabsSTTModels | str] = NOT_GIVEN, | ||
| keyterms: NotGivenOr[list[str]] = NOT_GIVEN, | ||
| no_verbatim: NotGivenOr[bool] = NOT_GIVEN, | ||
| enable_logging: bool = True, |
There was a problem hiding this comment.
| enable_logging: bool = True, | |
| enable_logging: NotGivenOr[bool] = NOT_GIVEN, |
could we widen the type here and only apply the parameter if it's given?
There was a problem hiding this comment.
I would be happy to add those changes, just one question before this.
I used the enable_logging logic from the TTS plugin as a base for this PR, ensuring that I propose a consistent update according to current implementation.
Does that mean the TTS implementation should be updated also or not using NotGivenOr was the right way?
If update is required, this is probably out of scope for this PR but worth to mention
| try: | ||
| async with self._ensure_session().post( | ||
| f"{self._opts.base_url}/speech-to-text", | ||
| f"{self._opts.base_url}/speech-to-text" |
There was a problem hiding this comment.
we can also have a helper method _synthesize_url to apply query parameters only if given
2 participants
Add enable_logging to 11labs STT, on par with already existing TTS implementation