feat(amd): optionally process SIP early media - #6940
Open
swayamg20 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait_until_answeredtoAMD, defaulting toTrueWhy
Some carriers deliver voicemail greetings or announcements through
183 Session Progressearly media beforesip.callStatusbecomesactive. AMD currently discards that audio while waiting for the answered state.This gives integrations an explicit opt-in without changing the safer default for calls where early media contains only ringback or dialtone. Callers that need a verdict before answer must also disable
wait_until_answeredon the SIP participant request.Testing
uv run pytest tests/test_amd_classifier.py -q— 37 passeduv run ruff check livekit-agents/livekit/agents/voice/amd/detector.py tests/test_amd_classifier.pyuv run ruff format --check livekit-agents/livekit/agents/voice/amd/detector.py tests/test_amd_classifier.pylivekit.agents— 207 source files passedCloses #6895