Fixes issue #1154 by forward-declaring PeerContext as struct#1231
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
OlympusM
changed the title
cloudwebrtc
approved these changes
Jul 9, 2026
Contributor
|
Hey @OlympusM, thank you for the fix. Could you please also add this |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the forward declaration of
PeerContextfrom aclassto astructinjsep.hto match how the type is generated by thecxxcrate on the Rust side.This resolves the name-mangling mismatch that causes 4x
LNK2019unresolved external symbol errors on stricter MSVC toolchains on Windows.Fixes #1154
Notes
Re-submitting this clean fix as the previous PR (#1167) was abandoned last month without a CLA signature. Verified locally that this compiles and passes all unit tests for
webrtc-sys.