Skip to content

Free input data pointer when rustbuffer_from_bytes throws #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1egoman merged 1 commit into from
May 12, 2026
Merged

Free input data pointer when rustbuffer_from_bytes throws #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions templates/sys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,24 +317,26 @@ export class UniffiRustBufferValue {
paramsValue: [bytes],
});

const rustBuffer = uniffiCaller.rustCall(
(callStatus) => {
return FFI_DYNAMIC_LIB.{{ci.ffi_rustbuffer_from_bytes().name()}}([
// TODO: figure out why this is necessary.
{ data: unwrapPointer([dataPointer])[0], len: bytes.byteLength },
callStatus,
]);
},
/*liftString:*/ {{ &Type::String | typescript_ffi_converter_name }}.lift,
);

freePointer({
paramsType: [arrayConstructor({ type: DataType.U8Array, length: bytes.byteLength })],
paramsValue: [dataPointer],
pointerType: PointerType.RsPointer
});

return new UniffiRustBufferValue(rustBuffer);
try {
const rustBuffer = uniffiCaller.rustCall(
(callStatus) => {
return FFI_DYNAMIC_LIB.{{ci.ffi_rustbuffer_from_bytes().name()}}([
// TODO: figure out why this is necessary.
{ data: unwrapPointer([dataPointer])[0], len: bytes.byteLength },
callStatus,
]);
},
/*liftString:*/ {{ &Type::String | typescript_ffi_converter_name }}.lift,
);

return new UniffiRustBufferValue(rustBuffer);
} finally {
freePointer({
paramsType: [arrayConstructor({ type: DataType.U8Array, length: bytes.byteLength })],
paramsValue: [dataPointer],
pointerType: PointerType.RsPointer
});
}
}

static allocateEmpty() {
Expand Down
Loading