Open
Conversation
This allows creating an entire pipeline via YAML files. Supported stages are: pass, transform, bundle and include. Includes are relative to the original yaml file. Bundles will be moved later, as they're still used by some examples. Migration of examples will come later, too, once we're happy with the design. See: https://github.com/llvm/lighthouse/wiki/Pipeline
fschlimb
reviewed
Mar 16, 2026
Comment on lines
+13
to
+18
| Pipeline: | ||
| - pass: PassName | ||
| - transform: TransformFile.mlir | ||
| - include: OtherPipeline.yaml | ||
| - bundle: BundleName | ||
| ... |
Contributor
There was a problem hiding this comment.
What about allowing arrays/list rather than just single entries? This could be very handy for yaml files whichi define a traditional pipeline, generally more than of the same kind in a sequence.
Member
Author
There was a problem hiding this comment.
A list is just a sub-pipeline, imported via include. Recursive even.
While a short list would look ok:
- pass: cse,canonicalize
a longer list would look better as multiple entries:
- pass: "one-shot-bufferize{function-boundary-type-conversion=identity-layout-map bufferize-function-boundaries},drop-equivalent-buffer-results,buffer-deallocation-pipeline"
vs.
- pass: one-shot-bufferize{function-boundary-type-conversion=identity-layout-map bufferize-function-boundaries}
- pass: drop-equivalent-buffer-results
- pass: buffer-deallocation-pipeline
Also, a list would need to allow different types (pass/transform/yaml/bundle) which would look even weirder (especially if one of the items is an include).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows creating an entire pipeline via YAML files. Supported stages are: pass, transform, bundle and include. Includes are relative to the original yaml file.
Bundles will be moved later, as they're still used by some examples. Migration of examples will come later, too, once we're happy with the design.
See: https://github.com/llvm/lighthouse/wiki/Pipeline