Removed Hardcoded SM Number from Mlir Test#186917
Open
Conversation
Member
|
@llvm/pr-subscribers-mlir-gpu Author: Stefan Mada (smada3) ChangesThis MR removes a hard-coded compute number in an MLIR test. This will allow the test to not need to be updated in the future. The default value will come from Full diff: https://github.com/llvm/llvm-project/pull/186917.diff 1 Files Affected:
diff --git a/mlir/test/Integration/GPU/CUDA/module-to-binary-compiler-log.mlir b/mlir/test/Integration/GPU/CUDA/module-to-binary-compiler-log.mlir
index a5c89b5704c85..0b2adcf224f03 100644
--- a/mlir/test/Integration/GPU/CUDA/module-to-binary-compiler-log.mlir
+++ b/mlir/test/Integration/GPU/CUDA/module-to-binary-compiler-log.mlir
@@ -4,7 +4,7 @@
module attributes {gpu.container_module} {
// CHECK-LABEL: gpu.binary @kernel_module
// CHECK: properties = {{{.*}}ISACompilerLog = {{.*}}
- gpu.module @kernel_module [#nvvm.target<chip = "sm_70", flags = {"collect-compiler-diagnostics"}>] {
+ gpu.module @kernel_module [#nvvm.target<flags = {"collect-compiler-diagnostics"}>] {
llvm.func @kernel(%arg0: i32, %arg1: !llvm.ptr,
%arg2: !llvm.ptr, %arg3: i64, %arg4: i64,
%arg5: i64) attributes {gpu.kernel} {
|
Member
|
@llvm/pr-subscribers-mlir Author: Stefan Mada (smada3) ChangesThis MR removes a hard-coded compute number in an MLIR test. This will allow the test to not need to be updated in the future. The default value will come from Full diff: https://github.com/llvm/llvm-project/pull/186917.diff 1 Files Affected:
diff --git a/mlir/test/Integration/GPU/CUDA/module-to-binary-compiler-log.mlir b/mlir/test/Integration/GPU/CUDA/module-to-binary-compiler-log.mlir
index a5c89b5704c85..0b2adcf224f03 100644
--- a/mlir/test/Integration/GPU/CUDA/module-to-binary-compiler-log.mlir
+++ b/mlir/test/Integration/GPU/CUDA/module-to-binary-compiler-log.mlir
@@ -4,7 +4,7 @@
module attributes {gpu.container_module} {
// CHECK-LABEL: gpu.binary @kernel_module
// CHECK: properties = {{{.*}}ISACompilerLog = {{.*}}
- gpu.module @kernel_module [#nvvm.target<chip = "sm_70", flags = {"collect-compiler-diagnostics"}>] {
+ gpu.module @kernel_module [#nvvm.target<flags = {"collect-compiler-diagnostics"}>] {
llvm.func @kernel(%arg0: i32, %arg1: !llvm.ptr,
%arg2: !llvm.ptr, %arg3: i64, %arg4: i64,
%arg5: i64) attributes {gpu.kernel} {
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR removes a hard-coded compute number in an MLIR test. This will allow the test to not need to be updated in the future. The default value will come from
NVVMOps.td.