Move Lavapipe targets to experimental tier#1371
Conversation
kmpeng
added
the
test-all
| matrix: | ||
| SKU: [windows-amd, windows-nvidia, windows-qc] | ||
| TestTarget: [check-hlsl-vk, check-hlsl-clang-vk] | ||
| TestTarget: [check-hlsl-vk, check-hlsl-clang-vk, check-hlsl-vk-lavapipe, check-hlsl-clang-vk-lavapipe] |
There was a problem hiding this comment.
I added Lavapipe to test-vk-all in addition to test-all, not sure if that's right
| exclude: | ||
| - { SKU: windows-nvidia, TestTarget: check-hlsl-d3d12 } | ||
| - { SKU: windows-nvidia, TestTarget: check-hlsl-clang-d3d12 } | ||
| - { SKU: windows-nvidia, TestTarget: check-hlsl-vk-lavapipe } |
There was a problem hiding this comment.
To be clear, I think this means we're excluding NVIDIA lavapipe targets from the extra / experimental tier.
Which means they work well. Is that right?
There was a problem hiding this comment.
We are "excluding" them from the experimental tier because there's no nvidia lavapipe config. Since the matrix is a SKU × TestTarget cross-product and windows-nvidia is needed for other targets, the excludes are just to drop the generated nvidia × lavapipe combos
There was a problem hiding this comment.
Ah that wasn't clear I thought we were excluding windows-nvidia because we only needed one x86 SKU covered by windows-amd and one aarch64 sku covered by windows-qc.
4 participants
Lavapipe targets were added as tier 1 targets in #1359, but since they're not completely passing yet, we should move them to the experimental tier.