Initialize lines = [] in load_log_files to avoid UnboundLocalError on FileNotFoundError retry failures#3879
Closed
Chessing234 wants to merge 1 commit into
Closed
Conversation
… FileNotFoundError retry failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
In
fastchat/serve/monitor/basic_stats.py, when all 5 retries to read a log file fail due to aFileNotFoundError, anUnboundLocalError: local variable 'lines' referenced before assignmentis raised atfor l in lines:.Root Cause:
linesis only assigned a value whenopen(filename).readlines()executes successfully inside thetryblock. If aFileNotFoundErroroccurs for all 5 attempts, the loop terminates withoutlinesbeing initialized, but the code still proceeds to accesslines.Why Fix is Correct:
By initializing
lines = []before starting the retry loop, we ensure thatlinesis always defined. If all retries fail, it remains an empty list, and the function gracefully skips the parsing loop and returns an empty list rather than crashing.