Skip to content

Fix for issue#663 on branch 6.x - #741

Merged
dhmlau merged 1 commit into
loopbackio:6.xfrom
manarhusrieh:6.x
Dec 11, 2024
Merged

Fix for issue#663 on branch 6.x#741
dhmlau merged 1 commit into
loopbackio:6.xfrom
manarhusrieh:6.x

Conversation

@manarhusrieh

@manarhusrieh manarhusrieh commented Dec 9, 2024

Copy link
Copy Markdown

Fixes: #663 #610

This is a rebase of the PR #666 on branch 6.x

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits

  • npm test passes on your machine
    image

  • New tests added or existing tests modified to cover all changes

  • Code conforms with the style guide

  • Commit messages are following our guidelines

closes: loopbackio#663

Signed-off-by: Manar Husrieh <manar.husrieh@gmail.com>

@dhmlau dhmlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, based on the approval/review on PR #666

@dhmlau

dhmlau commented Dec 11, 2024

Copy link
Copy Markdown
Member

Force merging this PR as tests pass on local machine.

@dhmlau
dhmlau merged commit d01a859 into loopbackio:6.x Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants