[hw] Split DV and DD for lowRISC vendored IPs - #612
Open
martin-velay wants to merge 3 commits into
Open
Conversation
martin-velay
force-pushed
the
split_dd_dv_opentitan
branch
2 times, most recently
from
June 16, 2026 15:26
15c23c1 to
ab0db08
Compare
martin-velay
force-pushed
the
split_dd_dv_opentitan
branch
2 times, most recently
from
July 17, 2026 07:00
2a25528 to
4aa3ac2
Compare
This would allow us to pull in the upstream DV files while maintmaining the DD files in the same state as before. This is needed as some RTL changes are not desired while we need to get latest DV changes from upstream. This will work until the DV diverge from the DD. Then, another solution will be needed to keep the DV and DD in sync (maybe cherry- picking individual changes in an OpenTitan fork dedicated to Mocha which will be manually maintained for Mocha needs). Signed-off-by: martin-velay <mvelay@lowrisc.org>
martin-velay
force-pushed
the
split_dd_dv_opentitan
branch
from
July 20, 2026 15:30
4aa3ac2 to
8e41c4a
Compare
Command: util/vendor.py --update hw/vendor/lowrisc_ip_dv.vendor.hjson Signed-off-by: martin-velay <mvelay@lowrisc.org>
Signed-off-by: martin-velay <mvelay@lowrisc.org>
martin-velay
force-pushed
the
split_dd_dv_opentitan
branch
from
July 20, 2026 15:33
8e41c4a to
0a563db
Compare
Contributor
Author
|
All looks good now: |
martin-velay
marked this pull request as ready for review
July 20, 2026 15:35
Comment on lines
+67
to
+69
| # vendor OpenTitan before doing the IP generation because patches might change the template. | ||
| # DD and DV vendors share a target_dir; run both before checking, since DD deletes IP dirs | ||
| # (including their dv/ subdirs) which the DV vendor then re-populates. |
Collaborator
There was a problem hiding this comment.
Regarding the ordering of dependencies: I checked this with Claude and I think now if we vendor the DD enviornment alone, it will remove the dv vendor. Is this constraint acceptable here, or should we add some glue logic to the scripts?
Contributor
Author
There was a problem hiding this comment.
I think we could still re-run the DV vendor script even if we don't update the Git hash version, just to get the files back. WDYT? Maybe you have a cleaner solution in mind?
Collaborator
There was a problem hiding this comment.
I think that's fine. We could technically exclude the the DD script from touching the DV directories on deletion, but this would be extra effort for limited returns. Maybe better to stay pragmatic.
tchilikov-semify
self-requested a review
July 31, 2026 09:35
tchilikov-semify
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow us to pull in the upstream DV files while maintmaining the DD files in the same state as before. This is needed as some RTL changes are not desired while we need to get latest DV changes from upstream. This will work until the DV diverge from the DD. Then, another solution will be needed to keep the DV and DD in sync (maybe cherry- picking individual changes in an OpenTitan fork dedicated to Mocha which will be manually maintained for Mocha needs).