DM-54540: bps report failed while reporting on a restarted task #88
DM-54540: bps report failed while reporting on a restarted task #88mxk62 wants to merge 8 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 84.78% 85.25% +0.46%
==========================================
Files 19 19
Lines 4260 4414 +154
Branches 458 463 +5
==========================================
+ Hits 3612 3763 +151
- Misses 570 575 +5
+ Partials 78 76 -2 ☔ View full report in Codecov by Harness. |
MichelleGower
left a comment
MichelleGower
left a comment
There was a problem hiding this comment.
3 bps restarts have held jobs and 2 bps restarts if some succeed one first restart doesn't have correct counts (like previously reported problem but need 1 more restart).
| # after the run is restarted. As HTCondorService.report() uses information | ||
| # in these files to determine job statuses, their absence may lead to | ||
| # reporting incorrect job status counts. | ||
| for subdag_dir in {file.parent for file in path.glob("subdags/*/*.rescue*")}: |
There was a problem hiding this comment.
What happens after 1 failure but works in next restart (but other things still fail)? The rescue files stay in the directory, so the report for a 2nd restart will have the same files missing for success problem, right? Was able to reproduce this by changing submit yaml to fail on two visit+detector 50 and manually changing executable to /usr/bin/true in the sub files for one visit+detector before the 1st restart.
If use the code in _update_rescue_file instead, that uses knowledge from the rescue file for what failed.
There was a problem hiding this comment.
If use the code in _update_rescue_file instead, that uses knowledge from the rescue file for what failed.
The _update_rescue_file() needs the name of the rescue file htc_backup_files() returns, but htc_backup_files() moved the files already when it is finished. On the other hand, _update_rescue_file() has no knowledge where the backup directory is. Point being, it not a "just". I'll need to change the information flow between these two functions
A bug was causing mixing up condor_dagman job data with those related to DAGMan jobs if `dag.nodes.log` was missing. Fixed that.
During workflow restarts, selected files are being moved to a dedicated backup directory as HTCondor recreates them with the fresh content once a workflow is restarted. However, the backup function was also moving out such files for subdags that succeeded. HTCondor does not rerun DAGs that completed successfully. Their absence led to reporting incorrect job status counts as the information in these files is used by the plugin's reporting mechanism. Made changes to ensure that only files of the failed subdags are backed up.
_udpate_rescue_file() was trying to back up files for each failed subdags However, at the time of its execution these files were already backed up. Also, the function, in its current implementation, doesn't have access to the correct location of the backup directory. As a result it was creating an empty directory tree in the directory with the failed subdag. Modified it so it has a single responsibility -- updating the rescue file of the main DAG.
The function responsible for backing up files between restarts was using a very simple strategy to determine if files in a subdag directory needs a backup -- if a subdag directory contained a rescue file, the files were backed up. This strategy turned out to be too simplistic. It erroneously was backing up files for subdags that completed successfully after a restart as rescue files from previous failures were still present. To address this limitation, now the subdags that fails (if any) are being retrieved directly from the main DAG rescue file.
Contrary to the names of the methods in all other test cases, the names of the methods in the ReadSingleNodeStatusTestCase were using snake_case instead of camelCase. Fixed that.
2 participants
Checklist
doc/changes