DM-55434 : Harden default ProvisioningScript#93
Closed
tcjennings wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## u/tobyj/check_job_nodeset #93 +/- ##
==========================================================
Coverage 84.78% 84.78%
==========================================================
Files 19 19
Lines 4260 4260
Branches 458 458
==========================================================
Hits 3612 3612
Misses 570 570
Partials 78 78 ☔ View full report in Codecov by Harness. |
tcjennings
force-pushed
the
tickets/DM-55434/tobyj
branch
2 times, most recently
from
485fe2a to
f7ae363
Compare
tcjennings
force-pushed
the
u/tobyj/check_job_nodeset
branch
from
659eb34 to
f5ca219
Compare
tcjennings
force-pushed
the
tickets/DM-55434/tobyj
branch
3 times, most recently
from
20bef23 to
83d490e
Compare
- trap SIGTERM in script and perform one final provisioner loop - keep provisionerJob alive until N consecutive allocateNodes failures
tcjennings
force-pushed
the
tickets/DM-55434/tobyj
branch
from
83d490e to
faed230
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the DAG provisioningJob for better signal handling and to ensure an attempt is made to allocate a glidein for finalJob if it needs one (e.g., glidein has expired but provisioner is evicted before final is submitted).
Checklist
doc/changes