Fix build error in BitSet getHash when building with MSVC#229
Open
ayhanefe wants to merge 1 commit into
Open
Conversation
ayhanefe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the project won’t build on MSVC 19.5 and boost 1.9 due to the getHash function in BitSet.cpp. I believe the issue is that boost::make_function_output_iterator() expects copy assignable. The simplest fix I should be to wrap the lambda in std::ref. This shouldn’t have performance impact.
I confirmed the project builds on MSVC and all the tests pass with this change