feat: add blockquote support to from_markdown() and Post.blockquote()#40
Open
ASRagab wants to merge 1 commit intoma2za:mainfrom
Open
feat: add blockquote support to from_markdown() and Post.blockquote()#40ASRagab wants to merge 1 commit intoma2za:mainfrom
ASRagab wants to merge 1 commit intoma2za:mainfrom
Conversation
5a454fc to
eddc6b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds blockquote (
>) support to both thefrom_markdown()parser and as a convenience method onPost.Changes
Post.blockquote(content)— new convenience method following the pattern ofheading(),horizontal_rule(), etc. Accepts string or pre-built paragraph content.from_markdown()— parses>prefixed lines into blockquote nodes using flush-based grouping (same pattern as bullet lists). Consecutive blockquote lines become a single blockquote with multiple paragraph children. Blank lines between blockquotes create separate blockquote nodes.parse_inline().Tests
Added 10 tests (8
from_markdownscenarios + 2blockquote()method tests):All 16 tests pass (6 existing + 10 new).
Motivation
Blockquotes are one of the most common Markdown elements but were not supported in
from_markdown(). This closes that gap while following the existing code patterns.