Skip to content

fix(svm): allow post-action executor after clone#24

Merged
GabrielePicco merged 8 commits into
mainfrom
fix/post-action-executor-privileged-access
Jun 3, 2026
Merged

fix(svm): allow post-action executor after clone#24
GabrielePicco merged 8 commits into
mainfrom
fix/post-action-executor-privileged-access

Conversation

@GabrielePicco
Copy link
Copy Markdown
Contributor

@GabrielePicco GabrielePicco commented Jun 2, 2026

Summary

  • Add a privileged-access mode in solana-svm for transactions shaped as Magic clone or clone-continue followed by PostAct.
  • Keep Magic-only control transactions fully privileged, but for clone -> PostAct only bypass the fee payer and the cloned account at instruction account index 1.
  • Reject malformed executor transactions that add extra non-delegated writable accounts, even when those accounts are also present as clone remaining accounts.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

Warning

Review limit reached

@GabrielePicco, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 50 minutes and 45 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6c84dda6-5dda-4dce-9ba7-5a815745854f

📥 Commits

Reviewing files that changed from the base of the PR and between 5bd1d56 and ed581e2.

📒 Files selected for processing (1)
  • svm/src/access_permissions.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/post-action-executor-privileged-access

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@GabrielePicco GabrielePicco marked this pull request as ready for review June 2, 2026 17:40
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1fd4c6474

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread svm/src/access_permissions.rs Outdated
@GabrielePicco GabrielePicco changed the title Allow post-action executor after clone fix(svm): allow post-action executor after clone Jun 2, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 16afe26b3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread svm/src/access_permissions.rs Outdated
Comment thread svm/src/access_permissions.rs Outdated
Comment thread svm/src/access_permissions.rs Outdated
Copy link
Copy Markdown

@snawaz snawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

EDIT: On a second look, I've some doubts and I'm seeing this PR again, in the context of magicblock-labs/magicblock-validator#1278.

Comment thread svm/src/access_permissions.rs Outdated
Copy link
Copy Markdown
Collaborator

@bmuddha bmuddha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit hacky and verbose, but I guess it can work as temporary solution. I think we can simplify it with the release of magicblock-engine, where we introduce magic program split, where only private instructions can use privileged mode.

Requested some changes related to code style.

Comment thread svm/src/access_permissions.rs Outdated
Comment thread svm/src/access_permissions.rs Outdated
Comment thread svm/src/access_permissions.rs Outdated
Comment thread svm/src/access_permissions.rs Outdated
Comment thread svm/src/access_permissions.rs Outdated
GabrielePicco and others added 4 commits June 3, 2026 10:23
Co-authored-by: Babur Makhmudov <31780624+bmuddha@users.noreply.github.com>
Co-authored-by: Babur Makhmudov <31780624+bmuddha@users.noreply.github.com>
Co-authored-by: Babur Makhmudov <31780624+bmuddha@users.noreply.github.com>
Co-authored-by: Babur Makhmudov <31780624+bmuddha@users.noreply.github.com>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 545a3ffa9e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread svm/src/access_permissions.rs Outdated
@GabrielePicco GabrielePicco requested a review from bmuddha June 3, 2026 08:33
Copy link
Copy Markdown
Collaborator

@bmuddha bmuddha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@GabrielePicco GabrielePicco merged commit b91ab7d into main Jun 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants