feat: anchor v1 support and backward compat#18
Conversation
WalkthroughWorkspace version bumped to 3.1.0 and internal session-keys* pins updated; Cargo manifests switched many dependencies to workspace-managed entries and added ChangesVersion, Dependencies, and Anchor Compatibility
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@version_align.sh`:
- Line 29: Update the sed invocation that edits Cargo.toml so it tolerates
varying whitespace around the dependency and version tokens: change the regex
used in the sed command that targets the session-keys dependency (the expression
beginning with /^session-keys[a-zA-Z0-9_-]* = / and the subsequent s/version =
"[^"]*"/...) to allow optional spaces around the equals signs (e.g., use
character classes or \s/[[:space:]]*/ for the spaces) and to match `version`
with optional whitespace before/after `=`; keep the same replacement value using
the shell $version variable and ensure the overall sed invocation name (the sed
line in version_align.sh) is updated accordingly so it won’t silently miss lines
like `version="..."` or `session-keys= "..."`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: c957ac9c-c4cc-4122-94d5-c55d636f8daf
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
Cargo.tomlprograms/gpl_session/Cargo.tomlprograms/gpl_session/macros/attribute/src/lib.rsprograms/gpl_session/src/lib.rsversion_align.sh
Problem
Enable support for Anchor v1 and backward compatibility
Solution
Summary by CodeRabbit