-
Notifications
You must be signed in to change notification settings - Fork 17
MT-23076: support api token expiration in create and reset #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oshchyhol
wants to merge
6
commits into
main
Choose a base branch
from
MT-23076-php-api-token-expiration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3ccb2d4
MT-23076: add TokenExpiration request value object
oshchyhol d30a42c
MT-23076: support expires_at when creating an api token
oshchyhol e6ec67d
MT-23076: support expires_at when resetting an api token
oshchyhol 457d02f
MT-23076: cover token expiration in api token tests
oshchyhol ec86c43
MT-23076: show token expiration in api tokens example
oshchyhol 93a64f0
MT-23076: list api tokens example in readme
oshchyhol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Mailtrap\DTO\Request\ApiToken; | ||
|
|
||
| use DateTimeInterface; | ||
|
|
||
| /** | ||
| * Optional token expiration as an ISO 8601 date-time. | ||
| * Omit the argument for the server default (a 1-year default is being rolled out). | ||
| * Use TokenExpiration::never() for a token that never expires. | ||
| * Past or more-than-5-years-ahead values are rejected with 422. | ||
| * | ||
| * Class TokenExpiration | ||
| */ | ||
| final class TokenExpiration | ||
| { | ||
| private function __construct(private ?string $value) | ||
| { | ||
| } | ||
|
|
||
| /** | ||
| * Expire the token at the given ISO 8601 date-time. | ||
| * | ||
| * @param DateTimeInterface|string $value | ||
| * | ||
| * @return self | ||
| */ | ||
| public static function at(DateTimeInterface|string $value): self | ||
| { | ||
| return new self( | ||
| $value instanceof DateTimeInterface ? $value->format(DateTimeInterface::ATOM) : $value | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Token never expires. | ||
| * | ||
| * @return self | ||
| */ | ||
| public static function never(): self | ||
| { | ||
| return new self(null); | ||
| } | ||
|
|
||
| public function getValue(): ?string | ||
| { | ||
| return $this->value; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use a relative future date in the runnable example.
Line 66 will send
2027-06-01T00:00:00Z. After June 1, 2027, server-side validation will reject this example withHttpClientException. Build the expiration from the current date instead.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents