Release 0.3.0: SimpleLineGraph, enum-class migration, examples, cleanup#8
Draft
jonfroehlich wants to merge 2 commits into
Draft
Release 0.3.0: SimpleLineGraph, enum-class migration, examples, cleanup#8jonfroehlich wants to merge 2 commits into
jonfroehlich wants to merge 2 commits into
Conversation
Features - Add SimpleLineGraph: simplest non-scrolling graph (persistent canvas, vertical bars, restarts at x=0). No history buffer. - Add 7 examples covering previously-uncovered classes: SimpleLineGraphA0, ScrollingLineGraphA0, ScrollingLineGraphTwoInputs, ButtonBasic, SmoothAnalogInput, ClosestColorMatch, ListSdFiles. Breaking - Scope all four public enums as enum class (ShapeType, PointSymbol, JoystickYDirection, GraphPrimitive). Enumerators must now be qualified (e.g. JoystickYDirection::RIGHT). Fixes a latent CIRCLE/TRIANGLE collision between ShapeType and PointSymbol when Shape.hpp and a graph header were included together. - Remove LineGraph.hpp / MultiValueScrollingLineGraph (superseded, unused; strict subset of ScrollingLineGraphMultiValue). Fixes - ScrollingLineGraphMultiValue now deletes its copy ctor/assignment (owns heap memory; prevents double-free on copy). - Guard MovingAverageFilter and ScrollingLineGraph against non-positive sizes. Housekeeping - Standardize on bool (over boolean) and nullptr (over NULL). - Shape::distance uses integer multiplication instead of pow(x, 2). - Remove dead code and commented-out debug prints; fill doc stubs. - Align example author footers to the shared convention. - Add CHANGELOG.md, docs/HARDWARE_TEST_PLAN.md, and CLAUDE.md. - CI installs the SD library (for the FileUtils example). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…bounce - Reorder constructor initializer list to declaration order (fixes a real -Wreorder warning; no behavior change). Verified warning-clean under --warnings all. - Add wasReleased() and wasJustPressed() edge detectors. The legacy wasPressed() (which actually fires on RELEASE) is kept for backwards compatibility — it now delegates to wasReleased() and is documented as release-firing. Several arduino-repo sketches depend on wasPressed(), so it is intentionally not renamed. - Add symmetric timeSinceLastRead() / lastReadTimestamp() so _lastReadTimestamp is no longer write-only dead state. - Read pins explicitly with (digitalRead(pin) == HIGH). - Document the lockout debounce strategy and its tradeoff. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.3.0 — SimpleLineGraph, enum-class migration, examples, and cleanup
Highlights
SimpleLineGraph— the simplest, non-scrolling graph (persistentcanvas, vertical bars, restarts at x=0; keeps no history buffer).
SimpleLineGraphA0,ScrollingLineGraphA0,ScrollingLineGraphTwoInputs,ButtonBasic,SmoothAnalogInput,ClosestColorMatch,ListSdFiles.Buttonquality pass — addedwasReleased()/wasJustPressed()edgedetectors, fixed a real
-Wreorderwarning, documented the debounce strategy.enum class(ShapeType,PointSymbol,JoystickYDirection,GraphPrimitive). Enumerators must be qualified —e.g.
JoystickYDirection::RIGHT,PointSymbol::CIRCLE. This fixes a latentCIRCLE/TRIANGLEcollision betweenShapeTypeandPointSymbolthat brokecompilation when
Shape.hppand a graph header were included together.LineGraph.hpp/MultiValueScrollingLineGraph— a superseded,unused draft (strict subset of
ScrollingLineGraphMultiValue). Verified zeroconsumers in this repo and in
makeabilitylab/arduino.Fixes & housekeeping
ScrollingLineGraphMultiValuedeletes its copy ctor/assignment (owns heap;prevents double-free).
MovingAverageFilterandScrollingLineGraph.bool(overboolean) andnullptr(overNULL).Shape::distance()uses integer multiplication instead ofpow(x, 2).example author footers.
CHANGELOG.md,docs/HARDWARE_TEST_PLAN.md,CLAUDE.md; CI installsthe
SDlibrary.Issues
CONTRIBUTING.md)🤖 Generated with Claude Code