Fix multiline Note rendering broken for dbdiagram.io parser#49
Open
miratcan wants to merge 1 commit into
Open
Conversation
- Fix table-level Note: multiline closing ''' now on its own line instead of at end of last content line, fixing dbdiagram.io parse errors for table notes. - Same fix for field-level multiline notes (note: '''...'''). The parser expects the closing triple single-quote to be on a separate line for proper multiline string termination.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DBML renderer outputs table-level and field-level multiline notes with the closing
'on the same line as the last content line.The dbdiagram.io (DBML) parser expects the closing
'to be on its own line for proper multiline string termination.Same fix applied to field-level
note: '''multiline attributes (e.g. verbose_name + help_text + choices).Before → dbdiagram.io import errors on any table with a note (M2M linking tables, or models with docstrings/comments).
After → clean import, all notes display correctly.