chore(headlamp): remove remaining resources - #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safety
The TunnelBinding and Dex static client were removed and verified in the preceding phase. The live Headlamp Application has
resources-finalizer.argocd.argoproj.io, so pruning it should cascade-delete Helm-managed namespaced and cluster-scoped resources instead of orphaning the cluster-admin binding.The Terraform-managed DNS record is intentionally handled separately after GitOps cleanup.
Validation
headlampreferenceskustomize build bootstrapkustomize build --enable-alpha-plugins --enable-exec operatorskustomize build workloads/appspre-commit run --all-files