Skip to content

chore: retire departed code owners (apps/live, ox configs) - #9504

Merged
sriramveeraghanta merged 3 commits into
previewfrom
chore/codeowners-apps-live-owner
Jul 29, 2026
Merged

chore: retire departed code owners (apps/live, ox configs)#9504
sriramveeraghanta merged 3 commits into
previewfrom
chore/codeowners-apps-live-owner

Conversation

@mguptahub

@mguptahub mguptahub commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Description

Two CODEOWNERS entries pointed at people who have left the makeplane org. GitHub silently ignores an entry whose owner lacks write access — no warning on the file view, no CI failure, no error anywhere. The path just quietly stops requesting a reviewer.

Path Was Now Effect of the stale entry
apps/live/ @Palanikannan1437 @saivallampati No effective owner — changes requested nobody
.oxlintrc.json, .oxfmtrc.json @sriramveeraghanta @lifeiscontent @sriramveeraghanta Dead token only — @sriramveeraghanta still resolved

@saivallampati is an org member and direct collaborator with write access, so the replacement entry actually resolves. @lifeiscontent is simply dropped: @sriramveeraghanta co-owns both ox configs and authored them, so those paths keep a real reviewer and no coverage gap is created. Every path in the file still has at least one owner with write access — verified against the org membership and collaborator APIs for all seven remaining owner tokens.

How this surfaced

While auditing why reviewers appear on release PRs. On #9160 (release: v1.4.0, 1506 files changed), @Palanikannan1437 was auto-requested off just 3 files under apps/live/. He still had write access when that PR opened in May 2026 — he doesn't now, which is how the gap opened without anyone noticing.

Note on timing

CODEOWNERS is read from the PR's base branch. This takes effect for PRs targeting preview once merged, and for PRs targeting master only after the next previewmaster release promotion.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Test Scenarios

  1. Open a PR against preview touching any file under apps/live/@saivallampati should be auto-requested.
  2. Open a PR against preview touching .oxlintrc.json or .oxfmtrc.json@sriramveeraghanta should be auto-requested, and @lifeiscontent should not appear.
  3. Confirm each remaining owner has the access the entry requires (it silently no-ops otherwise):
    for u in sriramveeraghanta dheeru0198 pablohashescobar saivallampati mguptahub; do
      echo -n "$u "
      gh api repos/makeplane/plane/collaborators/$u -i | head -1   # expect 204
    done
    Note: collaborators/<user>/permission returns read for any user on a public repo — that's the anonymous baseline, not a granted role. Use the collaborators/<user> 204/404 check as authoritative.
  4. Confirm GitHub reports no syntax warnings on the CODEOWNERS file view for this branch.

References

Summary by CodeRabbit

  • Chores
    • Updated code ownership assignments for the live application area.

Copilot AI review requested due to automatic review settings July 29, 2026 11:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6495c952-8227-4bdf-bb33-a4626a78e4b4

📥 Commits

Reviewing files that changed from the base of the PR and between 9c95ce6 and 16facbb.

📒 Files selected for processing (1)
  • CODEOWNERS
🚧 Files skipped from review as they are similar to previous changes (1)
  • CODEOWNERS

📝 Walkthrough

Walkthrough

The CODEOWNERS entry for apps/live/ changes its assigned owner from Palanikannan1437 to saivallampati.

Changes

CODEOWNERS ownership update

Layer / File(s) Summary
Update apps/live ownership
CODEOWNERS
The apps/live/ rule replaces the previous code owner with saivallampati.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: updating CODEOWNERS to retire departed owners.
Description check ✅ Passed The description follows the template and includes the required sections with substantive details, tests, and references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/codeowners-apps-live-owner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI review requested due to automatic review settings July 29, 2026 11:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@mguptahub mguptahub changed the title chore: update apps/live code owner to @Prashant-Surya chore: set apps/live code owner to @saivallampati (stale owner left the org) Jul 29, 2026
@mguptahub mguptahub changed the title chore: set apps/live code owner to @saivallampati (stale owner left the org) chore: set apps/live code owner to @saivallampati Jul 29, 2026
@mguptahub
mguptahub marked this pull request as ready for review July 29, 2026 12:02
@mguptahub
mguptahub marked this pull request as draft July 29, 2026 12:04
Copilot AI review requested due to automatic review settings July 29, 2026 12:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@mguptahub mguptahub changed the title chore: set apps/live code owner to @saivallampati chore: retire departed code owners (apps/live, ox configs) Jul 29, 2026
@mguptahub
mguptahub marked this pull request as ready for review July 29, 2026 12:07
@sriramveeraghanta
sriramveeraghanta merged commit 55610f4 into preview Jul 29, 2026
17 checks passed
@sriramveeraghanta
sriramveeraghanta deleted the chore/codeowners-apps-live-owner branch July 29, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants