chore: retire departed code owners (apps/live, ox configs) - #9504
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe ChangesCODEOWNERS ownership update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mguptahub
marked this pull request as ready for review
July 29, 2026 12:02
mguptahub
marked this pull request as draft
July 29, 2026 12:04
mguptahub
marked this pull request as ready for review
July 29, 2026 12:07
vihar
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two
CODEOWNERSentries pointed at people who have left themakeplaneorg. GitHub silently ignores an entry whose owner lacks write access — no warning on the file view, no CI failure, no error anywhere. The path just quietly stops requesting a reviewer.apps/live/@Palanikannan1437@saivallampati.oxlintrc.json,.oxfmtrc.json@sriramveeraghanta @lifeiscontent@sriramveeraghanta@sriramveeraghantastill resolved@saivallampatiis an org member and direct collaborator withwriteaccess, so the replacement entry actually resolves.@lifeiscontentis simply dropped:@sriramveeraghantaco-owns both ox configs and authored them, so those paths keep a real reviewer and no coverage gap is created. Every path in the file still has at least one owner with write access — verified against the org membership and collaborator APIs for all seven remaining owner tokens.How this surfaced
While auditing why reviewers appear on release PRs. On #9160 (
release: v1.4.0, 1506 files changed),@Palanikannan1437was auto-requested off just 3 files underapps/live/. He still had write access when that PR opened in May 2026 — he doesn't now, which is how the gap opened without anyone noticing.Note on timing
CODEOWNERSis read from the PR's base branch. This takes effect for PRs targetingpreviewonce merged, and for PRs targetingmasteronly after the nextpreview→masterrelease promotion.Type of Change
Screenshots and Media (if applicable)
Test Scenarios
previewtouching any file underapps/live/—@saivallampatishould be auto-requested.previewtouching.oxlintrc.jsonor.oxfmtrc.json—@sriramveeraghantashould be auto-requested, and@lifeiscontentshould not appear.collaborators/<user>/permissionreturnsreadfor any user on a public repo — that's the anonymous baseline, not a granted role. Use thecollaborators/<user>204/404 check as authoritative.CODEOWNERSfile view for this branch.References
Summary by CodeRabbit