Add generics support#273
Open
maybetm wants to merge 1 commit into
Open
Conversation
hduelme
requested changes
Jul 23, 2026
| "testData", | ||
| "build/test-libs" | ||
| ); | ||
|
|
Contributor
There was a problem hiding this comment.
Why did you changes this code? I think this could break building on other OS (Windows)
Comment on lines
210
to
212
| else if ( element instanceof PsiParameter psiParameter ) { | ||
| return psiParameter.getType(); | ||
| } |
Contributor
There was a problem hiding this comment.
How is it with PsiParameter (constructor target parameter)?
Comment on lines
140
to
142
| else if ( element instanceof PsiParameter psiParameter ) { | ||
| return psiParameter.getType(); | ||
| } |
Contributor
There was a problem hiding this comment.
What if the source is named e.g. entity.id?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!☺️ I noticed that the MapStruct IDEA plugin didn't support generics properly in some cases.
This PR adds support for generic types. I'd appreciate it if you could review and merge these changes!
Before
After