Project/Locate features#250
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #250 +/- ##
===========================================
+ Coverage 87.41% 87.60% +0.19%
===========================================
Files 205 211 +6
Lines 12461 12792 +331
Branches 1049 1084 +35
===========================================
+ Hits 10893 11207 +314
- Misses 1181 1188 +7
- Partials 387 397 +10 ☔ View full report in Codecov by Sentry. |
- add locate project type specifics on mutation
- update tutorial task schema - update locate tutorial test
- add new field task_partition_index - changes on temp to result table for locate project results
- add transparent icon color for locate custom option icon color
susilnem
force-pushed
the
project/locate-feature-workflow
branch
from
ab2eef2 to
1c83e8f
Compare
tnagorra
reviewed
May 7, 2026
tnagorra
reviewed
May 7, 2026
|
|
||
| client_id = factory.LazyFunction(lambda: str(ULID())) | ||
| reference = 1 | ||
| task_partition_index = factory.Sequence(lambda n: n) |
Collaborator
There was a problem hiding this comment.
This might not be correct!
tnagorra
reviewed
May 7, 2026
Comment on lines
+109
to
+112
| # NOTE: task_partition_index can be None, but if provided | ||
| # it should not be the same as any other task in the same scenario. | ||
| if task_partition_index is None: | ||
| return |
Collaborator
There was a problem hiding this comment.
We should check that task_partition_index is required for Locate tutorials
tnagorra
reviewed
May 7, 2026
| "Task partition index should be unique among tasks of the same scenario.", | ||
| ), | ||
| }, | ||
| ) |
Collaborator
There was a problem hiding this comment.
We also need to check that the task_partition_index is bounded to correct range.
tnagorra
reviewed
May 7, 2026
Comment on lines
+82
to
+83
| exportMetaKey=self.project_type_specifics.export_meta_key, | ||
| exportMetaValue=self.project_type_specifics.export_meta_value, |
Collaborator
There was a problem hiding this comment.
We need to add this to export.
tnagorra
previously approved these changes
May 7, 2026
- refactor hot geometry export generation logic
Feat: add e2e test for locate project
- Add street e2e data
chore(test): Add missing files on assets
tnagorra
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR doesn't introduce any:
printThis PR contains valid: