feat(renderer): set table download size policy at init#554
Open
kirangadhave wants to merge 2 commits into
Open
feat(renderer): set table download size policy at init#554kirangadhave wants to merge 2 commits into
kirangadhave wants to merge 2 commits into
Conversation
Contributor
Coverage Report
|
5 tasks
2f32823 to
e765461
Compare
There was a problem hiding this comment.
Pull request overview
Updates the VS Code notebook renderer to proactively disable large interactive table exports by configuring marimo’s table download size policy during renderer activation, and bumps the bundled marimo dependency to a newer release.
Changes:
- Bump bundled
marimofrom0.23.6→0.23.8(and update lockfile /.marimo-versionaccordingly). - Configure
downloadSizeLimitAtomin the VS Code renderer to cap table exports at 50 MB with a VS Code–specific tooltip message. - Re-export
downloadSizeLimitAtom/store(and related type) from the typed marimo frontend boundary to allow the renderer to set the policy.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Updates resolved marimo version and adds new dependency entries introduced by the bump. |
pyproject.toml |
Pins marimo==0.23.8 for the Python package environment. |
extension/src/renderer/renderer.tsx |
Sets the table download size policy on activation to disable export for large tables. |
extension/src/renderer/marimo-frontend.ts |
Adds typed imports/exports for the new download policy atom (and exports store). |
.marimo-version |
Updates the tracked bundled marimo version to 0.23.8. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sets downloadSizeLimitAtom to a 50 MB cap with a VS Code-specific message so marimo's table Export button disables up-front instead of silently failing inside the sandboxed NotebookRenderer.
e765461 to
e6f345c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #542
Sets
downloadSizeLimitAtom(introduced in marimo PR marimo-team/marimo#9510) to a 50 MB cap with a VS Code–specific message, so the table Export button disables up-front with a tooltip instead of silently failing inside the sandboxed NotebookRenderer.Why 50 MB
Empirically the sandbox download path and clipboard string limit start failing below 70 MB in testing. 50 MB is the conservative safe ceiling. The size gate uses JSON-serialized size (largest format we support) so if it fits, CSV/Parquet definitely fit.
Screen.Recording.2026-05-12.at.11.28.34.AM.mov
Test plan