refactor(ALab-Schema): modernized alab schema to be in sync with thei… - #2118
Open
bfoley12 wants to merge 3 commits into
Open
refactor(ALab-Schema): modernized alab schema to be in sync with thei…#2118bfoley12 wants to merge 3 commits into
bfoley12 wants to merge 3 commits into
Conversation
…r new data format
minhsueh
requested changes
Aug 3, 2026
| @@ -72,136 +58,131 @@ class Experiment(BaseModel, extra="forbid"): | |||
| default=None, description="Optional notes about the experiment" | |||
| ) | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
We also need
precursorPowders: list[str] | None = Field(
default=None,
description="List of precursor powder names used in the experiment",
)
Or, based on the discussion with Lauren, we would probably have
precursorPowders: list[PowderDose]
But in this case, PowderDose and ExperimentElement should not have rgNumber. While TemperatureLogEntry and XRDDataPoint would have correspondingrgNumber
Collaborator
Author
There was a problem hiding this comment.
Resolved, but leaving comment open for if we decide to move to list[PowderDose] after talking with Lauren
| last_updated: datetime = Field(description="Last modification timestamp") | ||
| lastUpdated: datetime = Field(description="Last modification timestamp") | ||
|
|
||
| status: Literal["completed", "error", "active", "unknown"] = Field( |
Collaborator
There was a problem hiding this comment.
Their data is capitalized, "Completed".
Collaborator
Author
There was a problem hiding this comment.
Do you know if this applies to their WorkflowTask.status?
Collaborator
There was a problem hiding this comment.
I am not sure; let's clarify with her tmr!
some fields had been removed during a refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r new data format
Summary
Worked with Lauren Walters to update A Lab's model schema to be in-sync with their data.