Skip to content

fixes #1973#1974

Merged
affeldt-aist merged 1 commit into
math-comp:masterfrom
mkerjean:PreTopologicalLmod_isConvexTvs20260517
May 17, 2026
Merged

fixes #1973#1974
affeldt-aist merged 1 commit into
math-comp:masterfrom
mkerjean:PreTopologicalLmod_isConvexTvs20260517

Conversation

@mkerjean
Copy link
Copy Markdown
Collaborator

Motivation for this change

Fixes #1973

There are missing instances at the end of the factory PreTopologicalLmod_isConvexTvs, so it only constructs a uniform space, not a ConvexTvs. This PR declares the missing instances via the PreTopologicalNmodule_isTopologicalNmodule, TopologicalNmodule_isTopologicalLmodule, and Uniform_isConvexTvs factories.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist self-requested a review May 17, 2026 07:27
Copy link
Copy Markdown
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! Since moreover this is already in use in a PR where it has been shown to work, let's merge. fyi: @Tragicus

@affeldt-aist affeldt-aist merged commit b9bfb0c into math-comp:master May 17, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Factory PreTopologicalLmod_isConvexTvs does not construct a ConvexTvs

2 participants