Combine language and speech language menus, and add empty locales for those that aren't implemented yet.#1510
Open
dpvc wants to merge 2 commits into
Open
Combine language and speech language menus, and add empty locales for those that aren't implemented yet.#1510dpvc wants to merge 2 commits into
dpvc wants to merge 2 commits into
Conversation
… those that aren't implemented yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR combines the two language menus in the Mathjax contextual menu into a single one that sets both the locale for SRE and the one used for MathJax's
Localeframework.It looks like it has a lot of files, but most are just empty JSON files for the locales that SRE has but that MathJax doesn't yet support. This allows the menu to include languages that are available in SRE, but not in the rest of MathJax, to be selected without causing error messages about missing localization files. I looked at the old v2 localizations to see if we could leverage any of that to fill in some of the new files, but it looked like there was not all that much overlap, even in the TeX messages, since there are now a lot more of them. I haven't tried to AI generate any of the missing data.
Currently the language menu is in the "Math Settings" submenu, but it's not really a setting about math per se. It might be better to move it up to the top-level menu right under "Math Settings". Thoughts?