Improved redirect URI check for MWP#587
Merged
Merged
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
james-hill-matomo
previously approved these changes
May 27, 2025
Contributor
james-hill-matomo
left a comment
james-hill-matomo
left a comment
There was a problem hiding this comment.
LGTM. I haven't tested this, have you?
Do we still need to check the original validUri as well?
snake14
reviewed
May 27, 2025
Contributor
snake14
left a comment
snake14
left a comment
There was a problem hiding this comment.
Looks good overall. I had one concern which I commented about.
snake14
previously approved these changes
May 28, 2025
snake14
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We received a bug report from some of our Matomo for WordPress customer that, they are getting an error when trying to import keywords for Google via SEKP plugin, since this plugin uses the same logic we have updated the function here too.
Issue No
-->
Steps to Replicate the Issue
Checklist