Describe the storage record types in our own terms - #53
Merged
Conversation
bjmeetsfo
force-pushed
the
oss/flat-write-path-and-crc32c
branch
from
August 19, 2026 05:57
7bc49ae to
7e4a58d
Compare
bjmeetsfo
changed the title
Wording-only follow-up covering the record types, completing the pass that already went through the rest of the crate. Descriptions stand on their own rather than being framed as comparisons, and three test names now say what they assert instead of what they were modelled on: field_numbers_match_the_on_disk_log_item_layout field_numbers_match_the_on_disk_index_log_layout band_states_keep_their_on_disk_numbering No behaviour change: comments, doc comments and those three test identifiers. Deliberately untouched -- serde alias attributes (on-disk backward compatibility; removing one stops existing data being read), configuration identifiers and environment variable names (renaming those is a breaking change for deployments), and our own type names. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
bjmeetsfo
force-pushed
the
oss/flat-write-path-and-crc32c
branch
from
August 19, 2026 06:00
7e4a58d to
d034be5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wording-only follow-up to the storage record types already on
main.The descriptions now stand on their own rather than being framed as comparisons, and three test names say what they assert instead of what they were modelled on:
field_numbers_match_the_on_disk_log_item_layoutfield_numbers_match_the_on_disk_index_log_layoutband_states_keep_their_on_disk_numberingNo behaviour change — comments, doc comments, and those three test identifiers. 74 passing in the touched areas.
Deliberately untouched:
aliasattributes — on-disk backward compatibility; removing one stops existing data from being read.