ci: fix coverage deployment manifest order - #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR fixes
The coverage merge workflow sorts the two BVT deployment names before comparing them, but the expected literal was in the opposite lexical order. Valid complementary manifests were therefore rejected after both multi-CN BVT jobs succeeded.
Observed in matrixorigin/matrixone#27080, run
31659940375, attempt 2:compose-proxy, group 1compose-pessimistic, group 0jqsorts those names ascompose-pessimistic, thencompose-proxy. This PR corrects the expected order.Validation
actionlintpassed.git diff --checkpassed.