Conversation
|
Newest code from mattermost has been published to preview environment for Git SHA 9fa3794 |
|
Newest code from mattermost has been published to preview environment for Git SHA 9a2ed57 |
|
Newest code from mattermost has been published to preview environment for Git SHA 0d96b59 |
|
Newest code from mattermost has been published to preview environment for Git SHA 4da4a85 |
|
Newest code from mattermost has been published to preview environment for Git SHA be54c5a |
|
Newest code from mattermost has been published to preview environment for Git SHA 855e76e |
|
Newest code from mattermost has been published to preview environment for Git SHA 3ebb08a |
|
Newest code from mattermost has been published to preview environment for Git SHA 62030ec |
|
Newest code from mattermost has been published to preview environment for Git SHA beabac2 |
|
Newest code from mattermost has been published to preview environment for Git SHA fb0154b |
|
Newest code from mattermost has been published to preview environment for Git SHA 67c50de |
|
Newest code from mattermost has been published to preview environment for Git SHA ce98172 |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 45 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (26)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
esethna
changed the title
|
Newest code from mattermost has been published to preview environment for Git SHA 2f420ba |
There was a problem hiding this comment.
Pull request overview
Reworks the Mattermost Calls documentation from a reference-style “deployment overview” into a phased, step-by-step deployment guide, and updates site navigation/links/redirects to point to the new guide and related sub-guides.
Changes:
- Adds a new phased “Mattermost Calls Deployment Guide” and removes the legacy Calls overview/deployment pages.
- Updates internal docs to link to the new Calls deployment guide + RTCD/offloader/logging pages.
- Adds redirects, MyST task list support, a new architecture image, and targeted CSS to improve table rendering in the new guide.
Reviewed changes
Copilot reviewed 25 out of 28 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| source/redirects.py | Adds/updates redirects from legacy Calls URLs to the new deployment guide and logging page. |
| source/product-overview/unsupported-legacy-releases.md | Updates a Calls highlight link (currently to a non-canonical URL). |
| source/product-overview/product-overview-index.rst | Updates Calls deployment doc link to the new deployment guide. |
| source/product-overview/plans.md | Updates Calls-related plan table links to the new guide/RTCD setup anchors. |
| source/product-overview/certifications-and-compliance.rst | Updates Calls deployment doc link to the new deployment guide. |
| source/images/calls-deployment-rtcd-recording.png | Adds a new RTCD + recording architecture diagram for the new guide. |
| source/end-user-guide/collaborate/make-calls.rst | Updates the dedicated RTCD reference link to the new deployment guide. |
| source/end-user-guide/collaborate/audio-and-screensharing.rst | Updates Calls deployment link to the new deployment guide. |
| source/deployment-guide/server/preparations.rst | Removes the old “Calls overview” link from the server prep list. |
| source/deployment-guide/server/linux/deploy-rhel.rst | Updates Calls/RTCD references to the new deployment guide and RTCD setup page. |
| source/deployment-guide/reference-architecture/deployment-scenarios/deploy-sovereign-collaboration.rst | Updates Calls/RTCD/offloader references to the new guide structure. |
| source/deployment-guide/reference-architecture/deployment-scenarios/deploy-mission-partner.rst | Updates Calls/RTCD/offloader references to the new guide structure. |
| source/deployment-guide/reference-architecture/deployment-scenarios/deploy-ddil-operations.rst | Updates Calls/RTCD/offloader references to the new guide structure. |
| source/deployment-guide/reference-architecture/deployment-scenarios/air-gapped-deployment.rst | Updates Calls references to point to the new deployment guide. |
| source/deployment-guide/deployment-guide-index.rst | Adds the Calls deployment guide into Deployment Guide navigation. |
| source/conf.py | Enables MyST tasklist extension to support checklists in the new guide. |
| source/administration-guide/configure/plugins-configuration-settings.rst | Updates Calls config doc cross-links to the new deployment guide. |
| source/administration-guide/configure/calls-rtcd-setup.md | Updates references to the new guide + logging page, and updates sizing link. |
| source/administration-guide/configure/calls-overview.rst | Removes the legacy Calls overview landing page. |
| source/administration-guide/configure/calls-offloader-setup.md | Updates references to the new guide + logging page. |
| source/administration-guide/configure/calls-metrics-monitoring.md | Updates references to the new guide + logging page. |
| source/administration-guide/configure/calls-logging.md | Renames/repurposes troubleshooting page to “Calls Logging” and fixes formatting. |
| source/administration-guide/configure/calls-kubernetes.md | Updates references to the new guide + logging page. |
| source/administration-guide/configure/calls-deployment.md | Removes the legacy Calls deployment overview page. |
| source/administration-guide/configure/calls-deployment-guide.md | Adds the new phased deployment guide with checklists, port tables, gates, and templates. |
| source/_static/css/homepage-v1.css | Adds targeted table layout CSS rules for the new deployment guide page. |
| #### Calls | ||
| - [Audio calling and screen sharing](https://docs.mattermost.com/configure/calls-deployment.html) in channels is now generally available to all Mattermost customers. | ||
| - [Audio calling and screen sharing](https://docs.mattermost.com/configure/calls-deployment-guide.html) in channels is now generally available to all Mattermost customers. | ||
| - Updated [the keyboard shortcut](https://docs.mattermost.com/channels/keyboard-shortcuts-for-channels.html#calls-shortcuts) to start and join calls. | ||
| - Please see [the docs](https://docs.mattermost.com/configure/plugins-configuration-settings.html#calls) for additional details on configuration setting updates. |
There was a problem hiding this comment.
Persona (Docs editor Evie) — Severity: Blocker
In #### Calls, the link points to https://docs.mattermost.com/configure/calls-deployment-guide.html, but this repo’s canonical URL is under /administration-guide/configure/… (and there’s no redirect entry for /configure/calls-deployment-guide.html). This will 404 in the published docs.
Also, the first bullet is missing the indentation used by the following list items, which can break list rendering/nesting.
Suggestion: change the URL to https://docs.mattermost.com/administration-guide/configure/calls-deployment-guide.html (or use an internal :doc: link), and align the bullet indentation with the other items in this section.
| - **Up to 50:** You can use the **Integrated** deployment mode. | ||
| - **More than 50:** You'll need to deploy an additional component called **RTCD** for handling media processing at scale. |
There was a problem hiding this comment.
Persona (Novice Nate) — Severity: Friction
This reads as a hard requirement: “More than 50: You'll need … RTCD”. Elsewhere in the docs, 50 is described as a recommended maximum/baseline, not an enforced limit; phrasing this as “need” may cause admins to over-provision or assume Integrated mode is impossible above 50.
Suggestion: reword to “recommended” and briefly explain that 50 is a practical baseline tied to sizing/performance, with RTCD strongly recommended for higher concurrency/production reliability.
| - **Up to 50:** You can use the **Integrated** deployment mode. | |
| - **More than 50:** You'll need to deploy an additional component called **RTCD** for handling media processing at scale. | |
| - **Up to 50:** You can typically use the **Integrated** deployment mode. This is a practical baseline for sizing and performance, not a hard limit. | |
| - **More than 50:** **RTCD** is strongly recommended for higher concurrency and production reliability because it handles media processing at scale. |
| - **Mattermost server**: Calls plugin is pre-installed, not additional infrastructure is needed. | ||
|
|
||
| **License** | ||
|
|
||
| - **Mattermost Entry**: 1:1 Calls + Screen Sharing |
There was a problem hiding this comment.
Persona (Docs editor Evie) — Severity: Blocker
In the Integrated tab, the license section says “Mattermost Entry: 1:1 Calls + Screen Sharing”, but editions-and-offerings.rst describes Entry as having “all features of Enterprise Advanced” with a “40-minute Calls” limit (no mention of restricting to 1:1 only). This mismatch can mislead admins about what Calls capabilities Entry includes.
Suggestion: update the Entry row to reflect the documented limitation (e.g., Calls time limit) and avoid implying it’s limited to 1:1 unless that’s explicitly true in product behavior.
(Also minor: “Calls plugin is pre-installed, not additional infrastructure is needed” → “no additional infrastructure is needed”.)
| - **Mattermost server**: Calls plugin is pre-installed, not additional infrastructure is needed. | |
| **License** | |
| - **Mattermost Entry**: 1:1 Calls + Screen Sharing | |
| - **Mattermost server**: Calls plugin is pre-installed, no additional infrastructure is needed. | |
| **License** | |
| - **Mattermost Entry**: Calls + Screen Sharing (40-minute limit) |
| | 3478 | UDP | Outbound | RTCD server | `stun.global.calls.mattermost.com` | (Optional - Step 1.3.1) Public IP discovery using STUN. | | ||
|
|
||
| ```{important} | ||
| If you use NGINX as a reverse proxy in front of Mattermost, note that NGINX cannot forward UDP traffic. Port 8443 must be opened directly on the server running the media service - not on NGINX. Port 443 is the only port NGINX handles for Calls. |
There was a problem hiding this comment.
Persona (Veteran Vince) — Severity: Friction
The note says “NGINX cannot forward UDP traffic”. Stock NGINX used as an HTTP reverse proxy can’t proxy UDP media, but NGINX can handle UDP via the stream module in some deployments. The current wording is overly absolute.
Suggestion: clarify the scope (e.g., “NGINX in HTTP reverse-proxy mode won’t proxy UDP media; ensure 8443 reaches the media service directly unless you’ve explicitly configured a UDP-capable proxy/load balancer”).
| If you use NGINX as a reverse proxy in front of Mattermost, note that NGINX cannot forward UDP traffic. Port 8443 must be opened directly on the server running the media service - not on NGINX. Port 443 is the only port NGINX handles for Calls. | |
| If you use NGINX as an HTTP reverse proxy in front of Mattermost, note that it won't proxy UDP media traffic in that configuration. Port 8443 should reach the server running the media service directly, unless you've explicitly configured a UDP-capable proxy or load balancer. Port 443 is the only port NGINX handles for Calls in the standard reverse-proxy setup. |
| When you execute each check below, `nmap` returns `open`, `closed`, or `filtered`. | ||
|
|
||
| **Pass**: | ||
| - `open`: Port is reachable and the service is running. Expected if you've already installed the RTCD or Recording services in Phases 3-4. | ||
| - `closed`: Port is reachable but the service is not running. Expected if you just provisioned the infrastructure in Step 1.4. | ||
|
|
||
| **Fail**: | ||
| - `filtered`: Firewall is blocking the port. Revisit your networking configuration in Step 1.5 before continuing. | ||
|
|
There was a problem hiding this comment.
Persona (Novice Nate) — Severity: Friction
The guide says UDP nmap will return only open, closed, or filtered, but UDP scans often show open|filtered (no response) even when a firewall is blocking or when the service is simply not replying. As written, readers may misinterpret results and get stuck in Phase 1.
Suggestion: mention open|filtered explicitly and how to interpret it in this context (or suggest an alternate validation method like nc -u/application-level checks once the service is running).
|
Newest code from mattermost has been published to preview environment for Git SHA c6d90dc |
|
Newest code from mattermost has been published to preview environment for Git SHA 0b53f3f |
|
Newest code from mattermost has been published to preview environment for Git SHA 123e2ec |
|
Newest code from mattermost has been published to preview environment for Git SHA 42fae25 |
|
Newest code from mattermost has been published to preview environment for Git SHA 3e209ae |
|
Newest code from mattermost has been published to preview environment for Git SHA f3e9de7 |
|
Newest code from mattermost has been published to preview environment for Git SHA 820d2b2 |
|
Newest code from mattermost has been published to preview environment for Git SHA 7b5e793 |
|
Newest code from mattermost has been published to preview environment for Git SHA e669e17 |
|
Newest code from mattermost has been published to preview environment for Git SHA 06952dd |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary