Skip to content

Add builtin validations for querystring parameter location#488

Merged
mattpolzin merged 5 commits intomattpolzin:mainfrom
ayushshrivastv:QuerystringBuiltins.swift
Apr 3, 2026
Merged

Add builtin validations for querystring parameter location#488
mattpolzin merged 5 commits intomattpolzin:mainfrom
ayushshrivastv:QuerystringBuiltins.swift

Conversation

@ayushshrivastv
Copy link
Copy Markdown
Contributor

Closes #450.

Summary

  • add a default builtin validation for OpenAPIKit querystring parameter rules
  • reject multiple querystring parameters within a Path Item or effective operation
  • reject mixing querystring and query parameters, including inherited Path Item parameters

Testing

  • swift test --filter BuiltinValidationTests -Xswiftc -strict-concurrency=complete
  • git diff --check

Copy link
Copy Markdown
Owner

@mattpolzin mattpolzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR still has the changes to external dereferencing concurrency that I asked be removed on your other PR, but other than that and the couple of small comments I left inline, this PR is looking like good coverage of the validation.

Copy link
Copy Markdown
Owner

@mattpolzin mattpolzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@mattpolzin mattpolzin merged commit 168e01f into mattpolzin:main Apr 3, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add built-in validations for OAS 3.2.0 querystring parameter location

2 participants